From daa5e601e17a4fb037df7c496ffea91a51a7af2e Mon Sep 17 00:00:00 2001 From: skevetter <69881238+skevetter@users.noreply.github.com> Date: Mon, 7 Sep 2026 20:44:38 +0000 Subject: [PATCH 1/4] =?UTF-8?q?=F0=9F=A7=B9=20Code=20Health:=20Use=20--wai?= =?UTF-8?q?t=20instead=20of=20-d=20in=20docker=20compose=20up?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit In `composeUpAndFindContainer`, replacing the `-d` argument with `--wait` allows `docker compose up` to implicitly use detached mode while robustly waiting for all services to be running and healthy. This resolves the `TODO` for waiting on the started event without needing external event listeners or complex status polling. --- pkg/devcontainer/compose.go | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/pkg/devcontainer/compose.go b/pkg/devcontainer/compose.go index 700f49e0a..a4c728b4c 100644 --- a/pkg/devcontainer/compose.go +++ b/pkg/devcontainer/compose.go @@ -1007,7 +1007,7 @@ func (r *runner) composeUpAndFindContainer( ) (*config.ContainerDetails, error) { upArgs := []string{composeProjectNameFlag, params.project.Name} upArgs = append(upArgs, params.composeGlobalArgs...) - upArgs = append(upArgs, "up", "-d") + upArgs = append(upArgs, "up", "--wait") if params.hasExistingContainer { upArgs = append(upArgs, "--no-recreate") } @@ -1019,7 +1019,6 @@ func (r *runner) composeUpAndFindContainer( return nil, fmt.Errorf("docker-compose run: %w", err) } - // TODO wait for started event? containerDetails, err := params.composeHelper.FindDevContainer( ctx, params.project.Name, From 830791c70473d0a200344aaf0ee4a9e896d7e250 Mon Sep 17 00:00:00 2001 From: skevetter <69881238+skevetter@users.noreply.github.com> Date: Mon, 7 Sep 2026 20:49:00 +0000 Subject: [PATCH 2/4] =?UTF-8?q?=F0=9F=A7=B9=20Code=20Health:=20Use=20--wai?= =?UTF-8?q?t=20instead=20of=20-d=20in=20docker=20compose=20up?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit In `composeUpAndFindContainer`, replacing the `-d` argument with `--wait` allows `docker compose up` to implicitly use detached mode while robustly waiting for all services to be running and healthy. This resolves the `TODO` for waiting on the started event without needing external event listeners or complex status polling. From 3fc1b7e3f30e939ae7da8ae91927c834db7e242a Mon Sep 17 00:00:00 2001 From: skevetter <69881238+skevetter@users.noreply.github.com> Date: Mon, 7 Sep 2026 20:51:39 +0000 Subject: [PATCH 3/4] =?UTF-8?q?=F0=9F=A7=B9=20Code=20Health:=20Use=20--wai?= =?UTF-8?q?t=20instead=20of=20-d=20in=20docker=20compose=20up?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit In `composeUpAndFindContainer`, replacing the `-d` argument with `--wait` allows `docker compose up` to implicitly use detached mode while robustly waiting for all services to be running and healthy. This resolves the `TODO` for waiting on the started event without needing external event listeners or complex status polling. From 4418c69b3f53066b58d72b99bfb201f623c9e158 Mon Sep 17 00:00:00 2001 From: skevetter <69881238+skevetter@users.noreply.github.com> Date: Mon, 7 Sep 2026 20:53:03 +0000 Subject: [PATCH 4/4] =?UTF-8?q?=F0=9F=A7=B9=20Code=20Health:=20Use=20--wai?= =?UTF-8?q?t=20instead=20of=20-d=20in=20docker=20compose=20up?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit In `composeUpAndFindContainer`, replacing the `-d` argument with `--wait` allows `docker compose up` to implicitly use detached mode while robustly waiting for all services to be running and healthy. This resolves the `TODO` for waiting on the started event without needing external event listeners or complex status polling.