From eb4dad9a6aa4ee233b8ec0ddb00bd421c260a9d3 Mon Sep 17 00:00:00 2001 From: Rohan Kumar Date: Mon, 21 Apr 2025 21:01:23 +0530 Subject: [PATCH] chore: fix dockerfile warnings reported during docker build - Use uppercase keyword in dockerfile as per convention - Split long RUN instruction into multiple lines for clarity - Use exec form for CMD instruction as done in ENTRYPOINT Signed-off-by: Rohan Kumar --- build/Dockerfile | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/build/Dockerfile b/build/Dockerfile index 10e1dad6b..4620d1d24 100644 --- a/build/Dockerfile +++ b/build/Dockerfile @@ -14,7 +14,7 @@ # # https://access.redhat.com/containers/?tab=tags#/registry.access.redhat.com/ubi9/go-toolset -FROM registry.access.redhat.com/ubi9/go-toolset:9.5-1739267472 as builder +FROM registry.access.redhat.com/ubi9/go-toolset:9.5-1739267472 AS builder ENV GOPATH=/go/ USER root WORKDIR /devworkspace-operator @@ -35,7 +35,12 @@ RUN make compile-webhook-server # https://access.redhat.com/containers/?tab=tags#/registry.access.redhat.com/ubi9-minimal FROM registry.access.redhat.com/ubi9-minimal:9.5-1739420147 -RUN microdnf -y update && microdnf clean all && rm -rf /var/cache/yum && echo "Installed Packages" && rpm -qa | sort -V && echo "End Of Installed Packages" +RUN microdnf -y update && \ + microdnf clean all && \ + rm -rf /var/cache/yum && \ + echo "Installed Packages" && \ + rpm -qa | sort -V && \ + echo "End Of Installed Packages" WORKDIR / COPY --from=builder /devworkspace-operator/_output/bin/devworkspace-controller /usr/local/bin/devworkspace-controller COPY --from=builder /devworkspace-operator/_output/bin/webhook-server /usr/local/bin/webhook-server @@ -49,6 +54,6 @@ RUN /usr/local/bin/user_setup USER ${USER_UID} ENTRYPOINT ["/usr/local/bin/entrypoint"] -CMD /usr/local/bin/devworkspace-controller +CMD ["/usr/local/bin/devworkspace-controller"] # append Brew metadata here