fix: keep Grok adapter ready when registry unverified

Author: rockyshi1993

scripts/lib/global-host-runtime-verifier.js

@@ -552,7 +552,6 @@ function verifyGlobalHostRuntime(options = {}) {
       probes.grokStatic = staticGrok
       issues.push(...staticGrok.issues)
       if (staticGrok.status === 'failed') contractStatus = 'failed'
-      else if (staticGrok.status === 'unverified' && contractStatus === 'passed') contractStatus = 'unverified'
     }
 
     const native = nativeVersionProbe(configurationHost.host, common)

scripts/test-global-host-config.js

@@ -451,10 +451,13 @@ assert(managedDriftRuntimeClaude.issues.some(issue =>
 assert.strictEqual(applyGlobalHostConfig({ packageRoot, env, home }).transaction.status, 'committed')
 const beforeGrokRegistration = inspectGlobalHostConfig({ packageRoot, env, home })
 assert.strictEqual(beforeGrokRegistration.ready, false)
-assert.strictEqual(
-  beforeGrokRegistration.hosts.find(host => host.host === 'grok').contractStatus,
-  'unverified'
-)
+const beforeGrokRegistrationHost = beforeGrokRegistration.hosts.find(host => host.host === 'grok')
+assert.strictEqual(beforeGrokRegistrationHost.adapterReady, true)
+assert.strictEqual(beforeGrokRegistrationHost.contractStatus, 'passed')
+assert.strictEqual(beforeGrokRegistrationHost.nativeStatus, 'unverified')
+assert(beforeGrokRegistrationHost.issues.some(issue =>
+  issue.code === 'GROK_PLUGIN_REGISTRY_UNVERIFIED'
+))
 const grokTarget = targets.find(target => target.host === 'grok')
 const registryFile = path.join(grokTarget.root, 'installed-plugins', 'registry.json')
 fs.mkdirSync(path.dirname(registryFile), { recursive: true })

scripts/test-global-host-runtime-verifier.js

@@ -104,6 +104,28 @@ assert.strictEqual(healthy.hosts.find(host => host.host === 'copilot').contractS
 assert.strictEqual(healthy.hosts.find(host => host.host === 'copilot').nativeStatus, 'unverified')
 assert.strictEqual(healthy.hosts.find(host => host.host === 'grok').nativeStatus, 'unverified')
 
+const missingRegistryFile = path.join(grokRoot, 'installed-plugins', 'registry.json')
+const missingRegistryContent = fs.readFileSync(missingRegistryFile, 'utf8')
+fs.unlinkSync(missingRegistryFile)
+const missingGrokRegistry = verifyGlobalHostRuntime({
+  configuration: {
+    mode: 'GlobalOnlyHostConfigModeV1',
+    workspaceCleanMode: 'GlobalOnlyWorkspaceCleanModeV1',
+    packageVersion: 'test',
+    hosts
+  },
+  env,
+  home,
+  fs,
+  spawnSync: spawnProbe
+})
+const missingRegistryGrok = missingGrokRegistry.hosts.find(host => host.host === 'grok')
+assert.strictEqual(missingRegistryGrok.adapterReady, true)
+assert.strictEqual(missingRegistryGrok.contractStatus, 'passed')
+assert.strictEqual(missingRegistryGrok.nativeStatus, 'unverified')
+assert(missingRegistryGrok.issues.some(issue => issue.code === 'GROK_PLUGIN_REGISTRY_UNVERIFIED'))
+fs.writeFileSync(missingRegistryFile, missingRegistryContent, 'utf8')
+
 const deepSpawn = (command, args) => {
   if (
     command === process.execPath &&

scripts/test-host-installation.js

@@ -755,7 +755,11 @@ console.log(`host installation tests passed selectors=5 dryRunWrites=0 collision
   const inspection = inspectGlobalHostConfig({ packageRoot: ROOT, env, home })
   assert.strictEqual(inspection.ready, false)
   assert.strictEqual(inspection.overallState, 'degraded')
-  assert.strictEqual(inspection.hosts.find(host => host.host === 'grok').contractStatus, 'unverified')
+  const grokInspection = inspection.hosts.find(host => host.host === 'grok')
+  assert.strictEqual(grokInspection.adapterReady, true)
+  assert.strictEqual(grokInspection.contractStatus, 'passed')
+  assert.strictEqual(grokInspection.nativeStatus, 'unverified')
+  assert(grokInspection.issues.some(issue => issue.code === 'GROK_PLUGIN_REGISTRY_UNVERIFIED'))
   assert.strictEqual(inspection.hosts.length, 5)
   assert.ok(fs.existsSync(path.join(home, 'gemini-cli-home', '.gemini', 'devcodex', 'global-host-receipt.json')))
   assert.ok(fs.existsSync(path.join(home, '.agents', 'devcodex', 'instructions.full.md')))
@@ -860,7 +864,7 @@ console.log(`host installation tests passed selectors=5 dryRunWrites=0 collision
   const statusAfterGlobalInstallFacts = JSON.parse(statusAfterGlobalInstall.stdout).payload
   assert.strictEqual(statusAfterGlobalInstallFacts.globalHostConfig.ready, false)
   assert.strictEqual(statusAfterGlobalInstallFacts.globalHostConfig.overallState, 'degraded')
-  assert.strictEqual(statusAfterGlobalInstallFacts.entryFiles.instructionProjection.grokPlugin.globalAdapterReady, false)
+  assert.strictEqual(statusAfterGlobalInstallFacts.entryFiles.instructionProjection.grokPlugin.globalAdapterReady, true)
   assert.strictEqual(statusAfterGlobalInstallFacts.entryFiles.instructionProjection.grokPlugin.workspaceSourceRequired, false)
   assert(!statusAfterGlobalInstallFacts.entryFiles.instructionProjection.issues.some(item =>
     item.code === 'HOST_GROK_WORKSPACE_PLUGIN_MISSING'
@@ -873,7 +877,7 @@ console.log(`host installation tests passed selectors=5 dryRunWrites=0 collision
   assert.strictEqual(doctorAfterGlobalInstall.status, 0, doctorAfterGlobalInstall.stderr || doctorAfterGlobalInstall.stdout)
   const doctorAfterGlobalInstallFacts = JSON.parse(doctorAfterGlobalInstall.stdout).payload
   assert.strictEqual(doctorAfterGlobalInstallFacts.globalHostConfig.ready, false)
-  assert.strictEqual(doctorAfterGlobalInstallFacts.installArtifacts.instructionProjection.grokPlugin.globalAdapterReady, false)
+  assert.strictEqual(doctorAfterGlobalInstallFacts.installArtifacts.instructionProjection.grokPlugin.globalAdapterReady, true)
   assert.strictEqual(doctorAfterGlobalInstallFacts.installArtifacts.instructionProjection.grokPlugin.workspaceSourceRequired, false)
   assert(!doctorAfterGlobalInstallFacts.installArtifacts.instructionProjection.issues.some(item =>
     item.code === 'HOST_GROK_WORKSPACE_PLUGIN_MISSING'