|
| 1 | +"""Verify target preservation and document state at the real Qt save boundary.""" |
| 2 | +import os |
| 3 | + |
| 4 | +import pytest |
| 5 | +from PySide6.QtCore import QSaveFile |
| 6 | +from PySide6.QtWidgets import QApplication, QMessageBox |
| 7 | + |
| 8 | +import core.tabs as tabs |
| 9 | + |
| 10 | + |
| 11 | +@pytest.fixture |
| 12 | +def document(tmp_path, monkeypatch): |
| 13 | + app = QApplication.instance() or QApplication([]) |
| 14 | + target = tmp_path / 'Grüße.py' |
| 15 | + target.write_bytes(b'original code\r\n') |
| 16 | + tab = tabs.EditorTab(target) |
| 17 | + tab.editor.setPlainText("print('Grüße')\n") |
| 18 | + tab.editor.document().setModified(True) |
| 19 | + errors = [] |
| 20 | + monkeypatch.setattr(QMessageBox, 'critical', lambda *args: errors.append(args)) |
| 21 | + yield tab, target, errors, app |
| 22 | + tab.editor.close() |
| 23 | + |
| 24 | + |
| 25 | +@pytest.mark.parametrize('failure', ['open', 'short', 'exception', 'commit']) |
| 26 | +def test_save_failure_preserves_existing_code_and_dirty_state(document, monkeypatch, failure): |
| 27 | + tab, target, errors, _ = document |
| 28 | + original_files = set(target.parent.iterdir()) |
| 29 | + |
| 30 | + class BrokenSaveFile(QSaveFile): |
| 31 | + def open(self, mode): |
| 32 | + assert not self.directWriteFallback() |
| 33 | + return False if failure == 'open' else super().open(mode) |
| 34 | + |
| 35 | + def write(self, payload): |
| 36 | + assert target.read_bytes() == b'original code\r\n' |
| 37 | + if failure in ('short', 'exception'): |
| 38 | + written = super().write(payload[:5]) |
| 39 | + if failure == 'exception': |
| 40 | + raise OSError('disk full after partial write') |
| 41 | + return written |
| 42 | + return super().write(payload) |
| 43 | + |
| 44 | + def commit(self): |
| 45 | + if failure == 'commit': |
| 46 | + self.cancelWriting() |
| 47 | + return super().commit() |
| 48 | + |
| 49 | + monkeypatch.setattr(tabs, 'QSaveFile', BrokenSaveFile) |
| 50 | + assert tab.save() is False |
| 51 | + assert target.read_bytes() == b'original code\r\n' |
| 52 | + assert tab.is_modified and tab.editor.document().isModified() |
| 53 | + assert len(errors) == 1 |
| 54 | + assert set(target.parent.iterdir()) == original_files |
| 55 | + |
| 56 | + |
| 57 | +def test_invalid_utf8_does_not_open_output(document, monkeypatch): |
| 58 | + tab, target, errors, _ = document |
| 59 | + monkeypatch.setattr(tab.editor, 'toPlainText', lambda: 'bad\ud800text') |
| 60 | + monkeypatch.setattr(tabs, 'QSaveFile', lambda *_: pytest.fail('output opened before encoding')) |
| 61 | + assert tab.save() is False |
| 62 | + assert target.read_bytes() == b'original code\r\n' |
| 63 | + assert tab.is_modified and tab.editor.document().isModified() |
| 64 | + assert len(errors) == 1 |
| 65 | + |
| 66 | + |
| 67 | +@pytest.mark.parametrize('text', ['', 'Grüße\nzweite Zeile\n']) |
| 68 | +def test_success_preserves_native_newlines_and_cleans_shared_document(document, text): |
| 69 | + tab, target, errors, _ = document |
| 70 | + clone = tabs.EditorTab.create_clone(tab) |
| 71 | + try: |
| 72 | + tab.editor.setPlainText(text) |
| 73 | + tab.editor.document().setModified(True) |
| 74 | + assert tab.save() is True |
| 75 | + assert target.read_bytes() == text.replace('\n', os.linesep).encode('utf-8') |
| 76 | + assert clone.editor.toPlainText() == text |
| 77 | + assert not tab.is_modified and not clone.is_modified |
| 78 | + assert not tab.editor.document().isModified() |
| 79 | + assert not errors |
| 80 | + finally: |
| 81 | + clone.editor.close() |
0 commit comments