fix(macOS): validate cached find ranges before Replace#244
Draft
cursor[bot] wants to merge 1 commit into
Draft
Conversation
Highlight ranges can lag the document while the find bar stays open because markdown restyle skips stale ranges in reapplySearchHighlights without removing them from lastSearchHighlightRanges. Replace then called replaceCharacters with an invalid range or wrong substring. Co-authored-by: Danny Peck <dannypeck@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
After the find/replace work, Replace / Replace & Find could use
lastSearchHighlightRangesthat no longer matched the liveNSTextStorage.reapplySearchHighlights()skips out-of-bounds ranges when re-tinting after markdown restyle, but it does not clear those entries from the cache. The user can keep editing while the find UI stays open, so Replace could callreplaceCharacters(in:with:)with an invalidNSRange(crash viaNSRangeException) or replace the wrong slice of text.Root cause
Stale cached highlight ranges coexisting with a mutated buffer; replace-current trusted the cache without re-validating against the current string.
Fix
LinkAwareTextView.cachedHighlightRangeStillMatchesQueryfor reuse and addSearchReplaceStaleHighlightTests.Validation