Skip to content

[FOLLOW-UP] docker job will fail once build-and-test is unblocked — Dockerfile has no SDK in build context #234

Description

@dcccrypto

Follow-up to #232 / #233.

Problem

The Dockerfile builder stage runs:

COPY package.json pnpm-lock.yaml pnpm-workspace.yaml ./
RUN pnpm install --frozen-lockfile

The lockfile resolves @percolatorct/sdk as file:../../percolator-sdk, which is not in the build context, so this will hit the same ENOENT ... scandir failure that #233 fixes for build-and-test.

Why it is not visible today

The docker job is gated behind needs: build-and-test and if: github.ref == 'refs/heads/main'. Since build-and-test has never passed, docker has never run.

#233 makes it reachable, so main is expected to go red here until this is fixed.

Likely fix

Mirror dcccrypto/percolator-indexer#175: check the SDK out into the build context (not as a sibling, as build-and-test needs), then COPY it to the path the lockfile expects. Note that inside the container WORKDIR /app, ../../percolator-sdk resolves to /percolator-sdk, so the destination differs from the indexer's.

Why it is not in #233

The Docker daemon was unavailable on the machine where #233 was verified, and I would rather not ship an unverified image-build change. Splitting it keeps #233 to something proven end-to-end.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions