fix(staging): reject byte-valued local path entries

Signed-off-by: Aakash Saravanan <aakash.saravanan@databricks.com>

Author: aakash-saravanan-db

examples/staging_ingestion.py

@@ -30,7 +30,8 @@
 2. Set the FILEPATH constant to the path of a file that will be uploaded (this example assumes its a CSV file)
 3. Run this file
 
-Note: staging_allowed_local_path accepts a path string or a list of path strings.
+Note: staging_allowed_local_path accepts a path string or a list of strings or
+os.PathLike objects that resolve to strings.
 """
 
 INGESTION_USER = "some.user@example.com"

src/databricks/sql/backend/kernel/client.py

@@ -582,17 +582,19 @@ def execute_command(
                         allowed_paths, (str, list)
                     ):
                         raise ProgrammingError(
-                            "staging_allowed_local_path must be a string or a list of paths"
+                            "staging_allowed_local_path must be a string or a list of strings or os.PathLike objects"
                         )
                     if isinstance(allowed_paths, str):
                         allowed_paths = [allowed_paths]
                     try:
                         normalized_paths = [
-                            os.fsdecode(path) for path in allowed_paths or []
+                            os.fspath(path) for path in allowed_paths or []
                         ]
+                        if any(not isinstance(path, str) for path in normalized_paths):
+                            raise TypeError("Local paths must resolve to strings")
                     except (TypeError, ValueError) as exc:
                         raise ProgrammingError(
-                            "staging_allowed_local_path must be a string or a list of paths"
+                            "staging_allowed_local_path must be a string or a list of strings or os.PathLike objects"
                         ) from exc
                     set_paths(normalized_paths)
                 elif staging_verb is not None:

tests/unit/test_kernel_client.py

@@ -862,7 +862,16 @@ def test_execute_command_forwards_allowed_local_paths(
 
 @pytest.mark.parametrize(
     "allowed",
-    [123, [object()], Path("/tmp/files"), ("/tmp/files",), (), {"/tmp/files": True}],
+    [
+        123,
+        [object()],
+        [b"/tmp/files"],
+        ["/tmp/files", b"/tmp/other"],
+        Path("/tmp/files"),
+        ("/tmp/files",),
+        (),
+        {"/tmp/files": True},
+    ],
 )
 @pytest.mark.parametrize(
     "operation",