From 0e27b300a58e14b6b24025883b91432ba45e0dfa Mon Sep 17 00:00:00 2001 From: George Pittarelli Date: Wed, 20 Feb 2019 14:30:25 -0800 Subject: [PATCH] Respect windowFeatures with falsy windowName Currently, if you do `blankshield.open('url', '', 'width=100')` the `'width=100'` (and any other windowFeatures) is effectively ignored because they actually get passed to `window.open` as the second argument (windowName). This change always fills in a windowName argument, so that windowFeatures will always be correctly passed as the third argument. --- blankshield.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/blankshield.js b/blankshield.js index e3eed02..33c4e87 100644 --- a/blankshield.js +++ b/blankshield.js @@ -174,6 +174,8 @@ openArgs = '"' + url + '"'; if (strWindowName) { openArgs += ', "' + strWindowName + '"'; + } else { + openArgs += ', ""'; } if (strWindowFeatures) { openArgs += ', "' + strWindowFeatures + '"';