Skip to content

When specifying cookieOptions, the middleware should keep any default setting that wasn't overridden. #41

@evert

Description

@evert

If a user provides cookieOptions, we throw out all defaults.

  const cookieOptions = options.cookieOptions || {
    path: '/',
    sameSite: 'lax',
    httpOnly: true,
  };

Instead we should keep all defaults and only use values that a user explicitly provided:

  const cookieOptions = {
    path: '/',
    sameSite: 'lax',
    httpOnly: true,
    ...options.cookieOptions
  };

cc @defrex

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions