From 69d36bbb6bb9250e8dd195ef3c10a7410cd7de52 Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Wed, 3 Jun 2026 03:46:59 +0000 Subject: [PATCH 1/2] chore(deps): update dependency @cucumber/biome-config to v0.2.1 --- javascript/package-lock.json | 6 +++--- javascript/package.json | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/javascript/package-lock.json b/javascript/package-lock.json index 4d6644da..6630cdbd 100644 --- a/javascript/package-lock.json +++ b/javascript/package-lock.json @@ -11,7 +11,7 @@ "devDependencies": { "@babel/core": "7.29.7", "@biomejs/biome": "^2.4.11", - "@cucumber/biome-config": "github:cucumber/biome-config#v0.1.0", + "@cucumber/biome-config": "github:cucumber/biome-config#v0.2.1", "@cucumber/compatibility-kit": "^29.1.4", "@cucumber/gherkin": "39.1.0", "@cucumber/gherkin-streams": "^6.0.0", @@ -485,8 +485,8 @@ } }, "node_modules/@cucumber/biome-config": { - "version": "0.0.0", - "resolved": "git+ssh://git@github.com/cucumber/biome-config.git#6e5b2a8a5fdffdb2f5b378e2f401254baa714f25", + "version": "0.2.1", + "resolved": "git+ssh://git@github.com/cucumber/biome-config.git#5ab9ace6ecb8fee6c5fbdeec8d3bb7438fd5659c", "dev": true, "license": "MIT" }, diff --git a/javascript/package.json b/javascript/package.json index dcbbb003..da35b23e 100644 --- a/javascript/package.json +++ b/javascript/package.json @@ -29,7 +29,7 @@ "devDependencies": { "@babel/core": "7.29.7", "@biomejs/biome": "^2.4.11", - "@cucumber/biome-config": "github:cucumber/biome-config#v0.1.0", + "@cucumber/biome-config": "github:cucumber/biome-config#v0.2.1", "@cucumber/compatibility-kit": "^29.1.4", "@cucumber/gherkin": "39.1.0", "@cucumber/gherkin-streams": "^6.0.0", From 7ed6a7289d719568e27a551687a9b197663f8e5a Mon Sep 17 00:00:00 2001 From: David Goss Date: Wed, 3 Jun 2026 08:59:59 +0100 Subject: [PATCH 2/2] fix violations --- javascript/src/CucumberHtmlStream.ts | 56 +++++++++++++++++++++------- 1 file changed, 42 insertions(+), 14 deletions(-) diff --git a/javascript/src/CucumberHtmlStream.ts b/javascript/src/CucumberHtmlStream.ts index 717f468a..91bdd9a8 100644 --- a/javascript/src/CucumberHtmlStream.ts +++ b/javascript/src/CucumberHtmlStream.ts @@ -48,20 +48,34 @@ export class CucumberHtmlStream extends Transform { } this.preMessageWritten = true this.writeTemplateBetween(null, '{{title}}', (err) => { - if (err) return callback(err) + if (err) { + return callback(err) + } this.push('Cucumber') this.writeTemplateBetween('{{title}}', '{{icon}}', (err) => { - if (err) return callback(err) + if (err) { + return callback(err) + } this.writeFile(this.iconPath, (err) => { - if (err) return callback(err) + if (err) { + return callback(err) + } this.writeTemplateBetween('{{icon}}', '{{css}}', (err) => { - if (err) return callback(err) + if (err) { + return callback(err) + } this.writeFile(this.cssPath, (err) => { - if (err) return callback(err) + if (err) { + return callback(err) + } this.writeTemplateBetween('{{css}}', '{{custom_css}}', (err) => { - if (err) return callback(err) + if (err) { + return callback(err) + } this.writeTemplateBetween('{{custom_css}}', '{{messages}}', (err) => { - if (err) return callback(err) + if (err) { + return callback(err) + } callback() }) }) @@ -74,13 +88,21 @@ export class CucumberHtmlStream extends Transform { private writePostMessage(callback: TransformCallback) { this.writePreMessageUnlessAlreadyWritten((err) => { - if (err) return callback(err) + if (err) { + return callback(err) + } this.writeTemplateBetween('{{messages}}', '{{script}}', (err) => { - if (err) return callback(err) + if (err) { + return callback(err) + } this.writeFile(this.jsPath, (err) => { - if (err) return callback(err) + if (err) { + return callback(err) + } this.writeTemplateBetween('{{script}}', '{{custom_script}}', (err) => { - if (err) return callback(err) + if (err) { + return callback(err) + } this.writeTemplateBetween('{{custom_script}}', null, callback) }) }) @@ -101,8 +123,12 @@ export class CucumberHtmlStream extends Transform { callback: (err?: Error | null) => void ) { this.readTemplate((err, template) => { - if (err) return callback(err) - if (!template) return callback(new Error('template is required if error is missing')) + if (err) { + return callback(err) + } + if (!template) { + return callback(new Error('template is required if error is missing')) + } const beginIndex = begin == null ? 0 : template.indexOf(begin) + begin.length const endIndex = end == null ? template.length : template.indexOf(end) this.push(template.substring(beginIndex, endIndex)) @@ -115,7 +141,9 @@ export class CucumberHtmlStream extends Transform { return callback(null, this.template) } fs.readFile(`${__dirname}/index.mustache`, { encoding: 'utf-8' }, (err, template) => { - if (err) return callback(err) + if (err) { + return callback(err) + } this.template = template return callback(null, template) })