From aebe946766b00102ab759f319bda3de09117fabc Mon Sep 17 00:00:00 2001 From: glennmichael123 Date: Fri, 4 Sep 2026 00:05:39 +0800 Subject: [PATCH] chore(ci): pin zig-js at #876, the first revision that builds on Zig 1963 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit main has been red on `zig-core` since #104 moved craft to 0.17.0-dev.1963. Every failure was in zig-js at the old pin — that toolchain appends `pointer_stability` to ArrayList, and zig-js had 27 struct literals and one JIT layout assertion that named the old shape. zig-utils/zig-js#876 fixes that upstream, verified there on 1963 (2285 passed, 0 failed) and on the 1818 its own CI pins (53/53 checks). This is the one-line pin to it. Locally, craft's full `zig build` and `zig build test` against this zig-js content on 1963: 153/153 steps, 2519 passed, 0 failed. --- .github/actions/first-party-zig-deps/pins.env | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/.github/actions/first-party-zig-deps/pins.env b/.github/actions/first-party-zig-deps/pins.env index 4cce75c6..1345f963 100644 --- a/.github/actions/first-party-zig-deps/pins.env +++ b/.github/actions/first-party-zig-deps/pins.env @@ -16,8 +16,14 @@ # Local development is unaffected: developers build against their own sibling # checkouts, and this file is read only by the CI action next to it. -# fix(lexer): size the SIMD identifier scan by lane count, not byte size (#625) -zig_js=eba3f7cfb8b32d6d84099b10f0e063fa0e0c53c7 +# fix(compat): stop describing ArrayList's layout, and read it instead (#876) +# +# The first pin this file needed for a reason other than "a push to main +# broke us": craft moved to Zig 0.17.0-dev.1963, which appends +# `pointer_stability` to ArrayList, and every zig-js revision before #876 +# fails to compile against it. #876 is the fix, verified on both 1963 and +# the 1818 zig-js's own CI pins. +zig_js=f9c2653e06568cd5bece232a45157e3f252f0a4c # fix(parser): make class-set construction failure-atomic (#20) zig_regex=cfb24da9f1dd9e759cefec7d6e1dfa094998e9d8