Fix error handling

Author: andrew-corbalt

pgutils/connector.go

@@ -73,32 +73,21 @@ func NewConnectionStringProviderFromURLString(ctx context.Context, rawURL string
 // ToConnector wraps a ConnectionStringProvider as a driver.Connector.
 // Each Connect(ctx) call asks the provider for a fresh DSN.
 func ToConnector(provider ConnectionStringProvider) driver.Connector {
-	if provider == nil {
-		panic("pgutils: ToConnector called with nil ConnectionStringProvider")
-	}
 	return &postgresqlConnector{connectionStringProvider: provider}
 }
 
 // WithSchemaSearchPath returns a ConnectionStringProvider that appends search_path
 // to the DSN produced by the underlying provider.
-//
-// This is a "must-style" helper intended for fluent call chaining.
-// It panics if provider is nil, if the underlying provider errors, or if the
-// search_path cannot be applied (e.g., already set).
 func WithSchemaSearchPath(provider ConnectionStringProvider, searchPath string) ConnectionStringProvider {
-	if provider == nil {
-		panic("pgutils: WithSchemaSearchPath called with nil ConnectionStringProvider")
-	}
-
 	return connectionStringProviderFunc(func(ctx context.Context) (string, error) {
 		dsn, err := provider.ConnectionString(ctx)
 		if err != nil {
-			panic(fmt.Errorf("pgutils: ConnectionString failed: %w", err))
+			return "", fmt.Errorf("ConnectionString failed: %w", err)
 		}
 
 		dsnWithPath, err := addSearchPathToURL(dsn, searchPath)
 		if err != nil {
-			panic(fmt.Errorf("pgutils: applying schema search path failed: %w", err))
+			return "", fmt.Errorf("applying schema search path failed: %w", err)
 		}
 
 		return dsnWithPath, nil