Skip to content

Review creation does not verify profile ownership #67

Description

@Aburke225

Problem

The POST /reviews endpoint passes the authenticated user's ID to create_review(), but core/services/review_service.py ignores that argument when creating a review.

The service creates a Review from the supplied profile_id without checking that the profile belongs to the current user. This is inconsistent with get_review() and list_reviews(), which already scope review reads through Profile.user_id.

Impact

An authenticated user who knows another user's profile UUID may be able to create a review for that profile by sending:

POST /reviews
{"profile_id": "<another-users-profile-id>"}

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingtier-2Intermediate difficulty

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions