refactor: move assignment out of conditional in get_dir_file_info

gr8man · gr8man · commit ff52364cfe2f · 2026-07-18T21:49:17.000+02:00
diff --git a/system/Helpers/filesystem_helper.php b/system/Helpers/filesystem_helper.php
@@ -281,8 +281,11 @@ function get_dir_file_info(string $sourceDir, bool $topLevelOnly = true, bool $r
                 if (is_dir($sourceDir . $file) && $file[0] !== '.' && $topLevelOnly === false) {
                     get_dir_file_info($sourceDir . $file . DIRECTORY_SEPARATOR, $topLevelOnly, true);
                 } elseif ($file[0] !== '.') {
-                    $fileData[$file]                  = get_file_info($sourceDir . $file);
-                    $fileData[$file]['relative_path'] = $relativePath;
+                    $info = get_file_info($sourceDir . $file);
+                    if ($info !== null) {
+                        $fileData[$file]                  = $info;
+                        $fileData[$file]['relative_path'] = $relativePath;
+                    }
                 }
             }
 

Original file line number	Diff line number	Diff line change
`@@ -281,8 +281,11 @@ function get_dir_file_info(string $sourceDir, bool $topLevelOnly = true, bool $r`
`281`	`281`	`if (is_dir($sourceDir . $file) && $file[0] !== '.' && $topLevelOnly === false) {`
`282`	`282`	`get_dir_file_info($sourceDir . $file . DIRECTORY_SEPARATOR, $topLevelOnly, true);`
`283`	`283`	`} elseif ($file[0] !== '.') {`
`284`		`- $fileData[$file] = get_file_info($sourceDir . $file);`
`285`		`- $fileData[$file]['relative_path'] = $relativePath;`
	`284`	`+ $info = get_file_info($sourceDir . $file);`
	`285`	`+ if ($info !== null) {`
	`286`	`+ $fileData[$file] = $info;`
	`287`	`+ $fileData[$file]['relative_path'] = $relativePath;`
	`288`	`+ }`
`286`	`289`	`}`
`287`	`290`	`}`
`288`	`291`