Skip to content

Commit dcffccc

Browse files
apply code suggestion
Co-authored-by: John Paul E Balandan <paulbalandan@gmail.com>
1 parent f82e8d6 commit dcffccc

2 files changed

Lines changed: 2 additions & 6 deletions

File tree

system/Log/Logger.php

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -377,11 +377,7 @@ protected function stringifyContextValue(int|string $key, mixed $value): string
377377
return '[object ' . $value::class . ']';
378378
}
379379

380-
if (is_resource($value)) {
381-
return '[resource ' . get_resource_type($value) . ']';
382-
}
383-
384-
return '[' . gettype($value) . ']';
380+
return '[' . get_debug_type($value) . ']';
385381
}
386382

387383
/**

tests/system/Log/LoggerTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -251,7 +251,7 @@ public function testLogInterpolatesResourceContextValue(): void
251251
Time::setTestNow('2023-11-25 12:00:00');
252252

253253
$resource = fopen('php://memory', 'rb');
254-
$expected = 'DEBUG - ' . Time::now()->format('Y-m-d') . ' --> Test message [resource stream]';
254+
$expected = 'DEBUG - ' . Time::now()->format('Y-m-d') . ' --> Test message [resource (stream)]';
255255

256256
$logger->log('debug', 'Test message {value}', ['value' => $resource]);
257257

0 commit comments

Comments
 (0)