apply code suggestions

michalsn · michalsn · commit a0cb18521c30 · 2025-10-09T20:45:56.000+02:00
diff --git a/system/DataCaster/Cast/EnumCast.php b/system/DataCaster/Cast/EnumCast.php
@@ -32,7 +32,7 @@ public static function get(
         mixed $value,
         array $params = [],
         ?object $helper = null,
-    ): mixed {
+    ): BackedEnum|UnitEnum {
         if (! is_string($value) && ! is_int($value)) {
             self::invalidTypeValueError($value);
         }
diff --git a/system/Entity/Cast/EnumCast.php b/system/Entity/Cast/EnumCast.php
@@ -20,7 +20,7 @@
 
 class EnumCast extends BaseCast
 {
-    public static function get($value, array $params = [])
+    public static function get($value, array $params = []): BackedEnum|UnitEnum
     {
         $enumClass = $params[0] ?? null;
 
diff --git a/utils/phpstan-baseline/loader.neon b/utils/phpstan-baseline/loader.neon
@@ -1,4 +1,4 @@
-# total 2768 errors
+# total 2767 errors
 
 includes:
     - argument.type.neon
diff --git a/utils/phpstan-baseline/missingType.iterableValue.neon b/utils/phpstan-baseline/missingType.iterableValue.neon
@@ -1,4 +1,4 @@
-# total 1362 errors
+# total 1361 errors
 
 parameters:
     ignoreErrors:
@@ -2417,11 +2417,6 @@ parameters:
             count: 1
             path: ../../system/Entity/Cast/EnumCast.php
 
-        -
-            message: '#^Method CodeIgniter\\Entity\\Cast\\EnumCast\:\:get\(\) return type has no value type specified in iterable type array\.$#'
-            count: 1
-            path: ../../system/Entity/Cast/EnumCast.php
-
         -
             message: '#^Method CodeIgniter\\Entity\\Cast\\EnumCast\:\:set\(\) has parameter \$value with no value type specified in iterable type array\.$#'
             count: 1

Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,7 @@ public static function get(`
`32`	`32`	`mixed $value,`
`33`	`33`	`array $params = [],`
`34`	`34`	`?object $helper = null,`
`35`		`- ): mixed {`
	`35`	`+ ): BackedEnum\|UnitEnum {`
`36`	`36`	`if (! is_string($value) && ! is_int($value)) {`
`37`	`37`	`self::invalidTypeValueError($value);`
`38`	`38`	`}`
Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@`
`20`	`20`
`21`	`21`	`class EnumCast extends BaseCast`
`22`	`22`	`{`
`23`		`- public static function get($value, array $params = [])`
	`23`	`+ public static function get($value, array $params = []): BackedEnum\|UnitEnum`
`24`	`24`	`{`
`25`	`25`	`$enumClass = $params[0] ?? null;`
`26`	`26`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-# total 2768 errors`
	`1`	`+# total 2767 errors`
`2`	`2`
`3`	`3`	`includes:`
`4`	`4`	`- argument.type.neon`