fix: resolve global state pollution causing random-order test failures in HTTP suite (#10372)

* fix: resolve random order execution failures in HTTP test suite

* fix: resolve encoding negotiation pollution in NegotiateTest

* style: run composer cs-fix on HTTP classes

* fix: remove redundant null check for string typed parameter in MessageTrait

* fix: address reviewer feedback regarding HTTP test isolation

* test: isolate CorsTest to prevent global state pollution

* test: enable random order execution verification for HTTP component

* test: move resetServices before parent::setUp in HTTP test suite to preserve parent mocks

Author: gr8man

.github/scripts/random-tests-config.txt

@@ -27,7 +27,7 @@ Events
 Files
 # Filters
 Format
-# HTTP
+HTTP
 # Helpers
 Honeypot
 HotReloader

tests/system/HTTP/CURLRequestTest.php

@@ -39,9 +39,9 @@ class CURLRequestTest extends CIUnitTestCase
 
     protected function setUp(): void
     {
+        $this->resetServices();
         parent::setUp();
 
-        $this->resetServices();
         Services::injectMock('superglobals', new Superglobals());
         $this->request = $this->getRequest();
     }

tests/system/HTTP/CorsTest.php

@@ -14,14 +14,22 @@
 namespace CodeIgniter\HTTP;
 
 use CodeIgniter\Test\CIUnitTestCase;
+use PHPUnit\Framework\Attributes\BackupGlobals;
 use PHPUnit\Framework\Attributes\Group;
 
 /**
  * @internal
  */
+#[BackupGlobals(true)]
 #[Group('Others')]
 final class CorsTest extends CIUnitTestCase
 {
+    protected function setUp(): void
+    {
+        $this->resetServices();
+        parent::setUp();
+    }
+
     /**
      * @param array{
      *      allowedOrigins?: list<string>,

tests/system/HTTP/DownloadResponseTest.php

@@ -20,6 +20,7 @@
 use CodeIgniter\Test\CIUnitTestCase;
 use DateTime;
 use DateTimeZone;
+use PHPUnit\Framework\Attributes\BackupGlobals;
 use PHPUnit\Framework\Attributes\Group;
 use PHPUnit\Framework\Attributes\PreserveGlobalState;
 use PHPUnit\Framework\Attributes\RunInSeparateProcess;
@@ -28,6 +29,7 @@
 /**
  * @internal
  */
+#[BackupGlobals(true)]
 #[Group('SeparateProcess')]
 final class DownloadResponseTest extends CIUnitTestCase
 {

tests/system/HTTP/IncomingRequestTest.php

@@ -43,6 +43,7 @@ final class IncomingRequestTest extends CIUnitTestCase
     #[WithoutErrorHandler]
     protected function setUp(): void
     {
+        $this->resetServices();
         parent::setUp();
 
         $_ENV = $_SESSION = [];
@@ -280,7 +281,7 @@ public function testSetValidLocales(): void
      */
     public function testNegotiatesLocale(): void
     {
-        service('superglobals')->setServer('HTTP_ACCEPT_LANGUAGE', 'fr-FR); q=1.0, en; q=0.5');
+        service('superglobals')->setServer('HTTP_ACCEPT_LANGUAGE', 'fr-FR; q=1.0, en; q=0.5');
 
         $config                   = new App();
         $config->negotiateLocale  = true;
@@ -295,7 +296,7 @@ public function testNegotiatesLocale(): void
 
     public function testNegotiatesLocaleOnlyBroad(): void
     {
-        service('superglobals')->setServer('HTTP_ACCEPT_LANGUAGE', 'fr); q=1.0, en; q=0.5');
+        service('superglobals')->setServer('HTTP_ACCEPT_LANGUAGE', 'fr; q=1.0, en; q=0.5');
 
         $config                   = new App();
         $config->negotiateLocale  = true;
@@ -349,7 +350,7 @@ public function testNegotiatesEncoding(): void
     public function testNegotiatesLanguage(): void
     {
         $this->request->setHeader('Accept-Language', 'da, en-gb;q=0.8, en;q=0.7');
-        $this->assertSame('en', $this->request->negotiate('language', ['en', 'da']));
+        $this->assertSame('da', $this->request->negotiate('language', ['en', 'da']));
     }
 
     public function testCanGrabGetRawJSON(): void

tests/system/HTTP/MessageTest.php

@@ -259,7 +259,11 @@ public function testPopulateHeadersWithoutContentType(): void
 
         $this->assertNull($this->message->header('content-type'));
 
-        putenv("CONTENT_TYPE={$originalEnv}");
+        if ($originalEnv !== false) {
+            putenv("CONTENT_TYPE={$originalEnv}");
+        } else {
+            putenv('CONTENT_TYPE');
+        }
     }
 
     public function testPopulateHeadersWithoutHTTP(): void

tests/system/HTTP/NegotiateTest.php

@@ -17,11 +17,13 @@
 use CodeIgniter\Test\CIUnitTestCase;
 use Config\App;
 use Config\Feature;
+use PHPUnit\Framework\Attributes\BackupGlobals;
 use PHPUnit\Framework\Attributes\Group;
 
 /**
  * @internal
  */
+#[BackupGlobals(true)]
 #[Group('Others')]
 final class NegotiateTest extends CIUnitTestCase
 {
@@ -30,6 +32,7 @@ final class NegotiateTest extends CIUnitTestCase
 
     protected function setUp(): void
     {
+        $this->resetServices();
         parent::setUp();
 
         $config          = new App();

tests/system/HTTP/RedirectResponseTest.php

@@ -24,6 +24,7 @@
 use Config\Modules;
 use Config\Routing;
 use Config\Services;
+use PHPUnit\Framework\Attributes\BackupGlobals;
 use PHPUnit\Framework\Attributes\Group;
 use PHPUnit\Framework\Attributes\PreserveGlobalState;
 use PHPUnit\Framework\Attributes\RunInSeparateProcess;
@@ -32,6 +33,7 @@
 /**
  * @internal
  */
+#[BackupGlobals(true)]
 #[Group('SeparateProcess')]
 final class RedirectResponseTest extends CIUnitTestCase
 {
@@ -46,9 +48,8 @@ final class RedirectResponseTest extends CIUnitTestCase
     #[WithoutErrorHandler]
     protected function setUp(): void
     {
-        parent::setUp();
-
         $this->resetServices();
+        parent::setUp();
 
         Services::injectMock('superglobals', new Superglobals());
         service('superglobals')->setServer('REQUEST_METHOD', 'GET');

tests/system/HTTP/ResponseTest.php

@@ -22,25 +22,26 @@
 use Config\App;
 use DateTime;
 use DateTimeZone;
+use PHPUnit\Framework\Attributes\BackupGlobals;
 use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\Attributes\Group;
 
 /**
  * @internal
  */
+#[BackupGlobals(true)]
 #[Group('Others')]
 final class ResponseTest extends CIUnitTestCase
 {
     private array $server;
 
     protected function setUp(): void
     {
-        Services::injectMock('superglobals', new Superglobals());
-        $this->server = service('superglobals')->getServerArray();
-
+        $this->resetServices();
         parent::setUp();
 
-        $this->resetServices();
+        Services::injectMock('superglobals', new Superglobals());
+        $this->server = service('superglobals')->getServerArray();
     }
 
     protected function tearDown(): void
@@ -169,6 +170,7 @@ public function testSetLink(): void
         Factories::injectMock('config', 'App', $config);
 
         $this->resetServices();
+        Services::injectMock('superglobals', new Superglobals([], []));
 
         $response = new Response($config);
         $pager    = service('pager');

tests/system/HTTP/UserAgentTest.php

@@ -14,11 +14,13 @@
 namespace CodeIgniter\HTTP;
 
 use CodeIgniter\Test\CIUnitTestCase;
+use PHPUnit\Framework\Attributes\BackupGlobals;
 use PHPUnit\Framework\Attributes\Group;
 
 /**
  * @internal
  */
+#[BackupGlobals(true)]
 #[Group('Others')]
 final class UserAgentTest extends CIUnitTestCase
 {
@@ -28,6 +30,7 @@ final class UserAgentTest extends CIUnitTestCase
 
     protected function setUp(): void
     {
+        $this->resetServices();
         parent::setUp();
 
         // set a baseline user agent