Skip to content

Logging may leak slack webhook secret #161

Description

@patrickZWY

The current:
except Exception as slack_exc:
logger.error(f"Failed to post Slack alert: {slack_exc}")

may leak slack webhook secret in the case of an unhandled application exception that triggers notify_slack_of_exception() because we currently send slack alert through our app and whether this slack notification is successful or not, urllib3's debug request log (if successful) or the full slack_exc info (if failed) may be in log.

Reproduce this if you plan to fix this.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions