From f5e5a3512ef084f671fb97aa5087362d1762f7dc Mon Sep 17 00:00:00 2001 From: Franz Heidl Date: Tue, 14 Jul 2026 17:15:28 +0200 Subject: [PATCH 1/5] feat(ui): update default authentication error message Signed-off-by: Franz Heidl --- .../src/components/SignInForm/SignInForm.component.tsx | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/packages/ui-components/src/components/SignInForm/SignInForm.component.tsx b/packages/ui-components/src/components/SignInForm/SignInForm.component.tsx index c813fae5d2..9aa4d4baec 100644 --- a/packages/ui-components/src/components/SignInForm/SignInForm.component.tsx +++ b/packages/ui-components/src/components/SignInForm/SignInForm.component.tsx @@ -31,7 +31,7 @@ export interface SignInFormProps extends Omit { - const errorMessage = error === true ? "Authentication failed" : typeof error === "string" ? error : null + const errorMessage = + error === true ? "Unable to authenticate the provided credentials." : typeof error === "string" ? error : null return (
From 8f1837761e9eec1005501b5f8374804c968eb2e8 Mon Sep 17 00:00:00 2001 From: Franz Heidl Date: Tue, 14 Jul 2026 17:19:55 +0200 Subject: [PATCH 2/5] feat(ui): update tests Signed-off-by: Franz Heidl --- .../src/components/SignInForm/SignInForm.test.tsx | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/packages/ui-components/src/components/SignInForm/SignInForm.test.tsx b/packages/ui-components/src/components/SignInForm/SignInForm.test.tsx index 31e4a26f75..5913faf433 100644 --- a/packages/ui-components/src/components/SignInForm/SignInForm.test.tsx +++ b/packages/ui-components/src/components/SignInForm/SignInForm.test.tsx @@ -76,23 +76,23 @@ describe("SignInForm Component Tests", () => { describe("Error Prop", () => { test("does not display error message by default", () => { render() - expect(screen.queryByText("Authentication failed")).not.toBeInTheDocument() + expect(screen.queryByText("Unable to authenticate the provided credentials.")).not.toBeInTheDocument() }) test("does not display error when error={false}", () => { render() - expect(screen.queryByText("Authentication failed")).not.toBeInTheDocument() + expect(screen.queryByText("Unable to authenticate the provided credentials.")).not.toBeInTheDocument() }) test("displays default error message when error={true}", () => { render() - expect(screen.getByText("Authentication failed")).toBeInTheDocument() + expect(screen.getByText("Unable to authenticate the provided credentials.")).toBeInTheDocument() }) test("displays custom error message when error is a string", () => { render() expect(screen.getByText("Invalid credentials. Please try again.")).toBeInTheDocument() - expect(screen.queryByText("Authentication failed")).not.toBeInTheDocument() + expect(screen.queryByText("Unable to authenticate the provided credentials.")).not.toBeInTheDocument() }) test("error message renders as Message component with error variant", () => { @@ -104,7 +104,7 @@ describe("SignInForm Component Tests", () => { test("does not render error when error is empty string", () => { render() - expect(screen.queryByText("Authentication failed")).not.toBeInTheDocument() + expect(screen.queryByText("Unable to authenticate the provided credentials.")).not.toBeInTheDocument() }) }) From f34a7e0513f472f330ed43145d298f1c0828a50c Mon Sep 17 00:00:00 2001 From: Franz Heidl Date: Tue, 14 Jul 2026 17:21:05 +0200 Subject: [PATCH 3/5] feat(ui): add default error story Signed-off-by: Franz Heidl --- .../components/SignInForm/SignInForm.stories.tsx | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/packages/ui-components/src/components/SignInForm/SignInForm.stories.tsx b/packages/ui-components/src/components/SignInForm/SignInForm.stories.tsx index ad7cf4fcef..b7380e27c2 100644 --- a/packages/ui-components/src/components/SignInForm/SignInForm.stories.tsx +++ b/packages/ui-components/src/components/SignInForm/SignInForm.stories.tsx @@ -65,6 +65,22 @@ export const Default: Story = { }, } +export const WithError: Story = { + parameters: { + docs: { + description: { + story: "Sign-in form displaying the default authentication error message when `error={true}` is passed.", + }, + }, + }, + args: { + title: "Sign In", + error: true, + resetPwUrl: "#", + children: commonFormChildren(), + }, +} + export const AdditionalInputs: Story = { parameters: { docs: { From 2308af47eca52404087025bdc413606028d20741 Mon Sep 17 00:00:00 2001 From: Franz Heidl Date: Tue, 14 Jul 2026 17:30:44 +0200 Subject: [PATCH 4/5] Create shiny-clowns-divide.md Signed-off-by: Franz Heidl --- .changeset/shiny-clowns-divide.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/shiny-clowns-divide.md diff --git a/.changeset/shiny-clowns-divide.md b/.changeset/shiny-clowns-divide.md new file mode 100644 index 0000000000..487cc04602 --- /dev/null +++ b/.changeset/shiny-clowns-divide.md @@ -0,0 +1,5 @@ +--- +"@cloudoperators/juno-ui-components": patch +--- + +feat(ui): update `SignInForm` default authentication error message From 17b5f824f69ec2fb530ad2e1571651afd08eb391 Mon Sep 17 00:00:00 2001 From: Franz Heidl Date: Wed, 15 Jul 2026 10:48:03 +0200 Subject: [PATCH 5/5] feat(ui): set button type to button to prevent storybook error Signed-off-by: Franz Heidl --- .../src/components/SignInForm/SignInForm.stories.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/ui-components/src/components/SignInForm/SignInForm.stories.tsx b/packages/ui-components/src/components/SignInForm/SignInForm.stories.tsx index b7380e27c2..6425ffb208 100644 --- a/packages/ui-components/src/components/SignInForm/SignInForm.stories.tsx +++ b/packages/ui-components/src/components/SignInForm/SignInForm.stories.tsx @@ -44,7 +44,7 @@ const commonFormChildren = (additionalInputs?: React.ReactNode) => [ {additionalInputs} , - , ]