Small UX improvements for the nREPL messages buffer#3927
Merged
Conversation
The auto-follow in nrepl-log-message unconditionally jerked any window showing the messages buffer back to point-max on every new request or response, which made it impossible to read history while traffic was flowing. Snapshot which windows were at end-of-buffer before the insert and only scroll those; leave windows the user has scrolled back alone.
Previously the only way to empty the messages log was M-x erase-buffer after manually un-setting buffer-read-only. Bind c in nrepl-messages-mode to nrepl-clear-messages, which does it under inhibit-read-only and refuses to run outside a messages buffer.
Previously the only way to find the messages buffer was to remember its template-generated name and dig it out of the buffer list. The new command finds live nrepl-messages-mode buffers; with one connection it pops it directly, with several it prompts. Bundles a CHANGELOG entry for all three nREPL log UX changes on this branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few quality-of-life tweaks for
*nrepl-messages*. Auto-follow no longer rips windows you've scrolled back away from the latest entry, you can wipe the buffer withc(newnrepl-clear-messages), andM-x nrepl-show-messagespops it up without having to remember the template-generated name.eldev test)eldev lint)