Skip to content

Removal of com.github.doyaaaaaken:kotlin-csv-jvm depencency #7

@gfasser

Description

@gfasser

Currently, kotlin-csv-jvm is used on a single line of code for a relatively simple use case: reading and parsing a simple CSV file.

csvReader()
.readAllWithHeader(releaseNotesFile)
.map { row ->
val version = row.values.first()
val releaseNotes = row
.entries
.filterIndexed { index, _ -> index != 0 }
.map { languageToReleaseNote ->
LocalizedText().apply {
language = languageToReleaseNote.key
text = languageToReleaseNote.value
}
}
log("Found release notes for version $version with languages: ${releaseNotes.map { it.language }}")
Pair(version, releaseNotes)

With a use case as simple as this one, using an entire CSV library seems a bit overkill with the downside of adding an external dependency to the project (which comes with the usual downsides of 3rd party dependencies).

I propose we remove the kotlin-csv-jvm dependency entirely and implement the currently required functionality ourselves.

Any thoughts or counter arguments on the topic, @chippmann ?

Metadata

Metadata

Assignees

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions