Fix Docker runtime healthcheck by including wget in final image#136
Conversation
cbulock
left a comment
There was a problem hiding this comment.
No code-level issues found.
The change directly fixes the observed runtime failure: the container healthcheck calls wget, and the final image now installs wget alongside ffmpeg while preserving the existing healthcheck script and endpoint behavior.
One validation caveat before merging: the CI run for the current head SHA is currently action_required, so the Docker build/CI has not completed yet. I’d let CI run before merging.
There was a problem hiding this comment.
Pull request overview
This PR fixes a runtime/container packaging issue where the Docker healthcheck script depends on wget, but wget was not installed in the final production image—causing the container to be marked unhealthy even when the app was running.
Changes:
- Install
wgetalongsideffmpegin the final Docker image stage to satisfy/usr/src/app/healthcheck.sh. - Keep the existing healthcheck script and health endpoint contract unchanged.
Docker marked
iptv-proxyunhealthy even when the app was running because the healthcheck script invokedwget, which was not present in the runtime image. This PR resolves the dependency mismatch without changing healthcheck behavior.Runtime image dependency alignment
Dockerfileto includewgetalongsideffmpeg./usr/src/app/healthcheck.shcontract intact (wget --spider http://localhost:34400/health).Scope
RUN apt-get update && \ apt-get install -y --no-install-recommends ffmpeg wget && \ rm -rf /var/lib/apt/lists/*