From a6715f4b0a3921280352fd2935dad1a31d949835 Mon Sep 17 00:00:00 2001 From: Claude Date: Sun, 11 Oct 2026 20:37:54 +0000 Subject: [PATCH 1/2] fix(yemot): save phone transport lateness on student's morning klass MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Transport lateness reported by phone was saved on an arbitrary student klass (usually the base klass). Prefer the student's current-year klass whose name starts with "בוקר"; fall back to previous behavior when none. Co-Authored-By: Claude Opus 5.5 Claude-Session: https://claude.ai/code/session_01Rubw4xHpfDfDmWWoZSQovN --- server/src/yemot-handler.service.test.ts | 47 ++++++++++++++++++++++++ server/src/yemot-handler.service.ts | 15 +++++++- 2 files changed, 60 insertions(+), 2 deletions(-) diff --git a/server/src/yemot-handler.service.test.ts b/server/src/yemot-handler.service.test.ts index 053e9836..02ec22c6 100644 --- a/server/src/yemot-handler.service.test.ts +++ b/server/src/yemot-handler.service.test.ts @@ -278,6 +278,53 @@ describe('YemotHandlerService — react-admin-nestjs', () => { expect(result.hungup).toBe(true); }); + it('morning klass — transport lateness saved on the "בוקר" klass, not the base klass', async () => { + jest.setSystemTime(israelTimeAt(7, 0)); + const year = getCurrentHebrewYear(); + + const builder = transportSetup('Morning klass', { + studentKlass: { ...defaultStudentKlass, year }, + extraSeeds: { + Klass: [ + { id: 200, userId: 1, key: 1, name: 'ה1', year }, + { id: 201, userId: 1, key: 2, name: 'בוקר ה1', year }, + ], + StudentKlass: [ + { ...defaultStudentKlass, year }, + { id: 51, userId: 1, studentReferenceId: 100, klassReferenceId: 201, year }, + ], + KnownAbsence: [], + }, + }); + respondToTz(builder, '123456789'); + respondToTransport(builder, '5'); + confirmDeparture(builder, true); + const scenario = builder.systemHangsUp(/success/i).build(); + + const result = await runner.run(scenario); + expect(result.passed).toBe(true); + expect(result.saved['KnownAbsence']).toHaveLength(1); + expect(result.saved['KnownAbsence'][0].klassReferenceId).toBe(201); + }); + + it('no morning klass — transport lateness falls back to the student klass', async () => { + jest.setSystemTime(israelTimeAt(7, 0)); + const year = getCurrentHebrewYear(); + + const builder = transportSetup('No morning klass', { + studentKlass: { ...defaultStudentKlass, year }, + extraSeeds: { Klass: [{ id: 200, userId: 1, key: 1, name: 'ה1', year }], KnownAbsence: [] }, + }); + respondToTz(builder, '123456789'); + respondToTransport(builder, '5'); + confirmDeparture(builder, true); + const scenario = builder.systemHangsUp(/success/i).build(); + + const result = await runner.run(scenario); + expect(result.passed).toBe(true); + expect(result.saved['KnownAbsence'][0].klassReferenceId).toBe(200); + }); + it('past deadline — exactly at 8:50, hangup with CLOSED', async () => { jest.setSystemTime(israelTimeAt(8, 50)); diff --git a/server/src/yemot-handler.service.ts b/server/src/yemot-handler.service.ts index 4e1dcb9f..44900696 100644 --- a/server/src/yemot-handler.service.ts +++ b/server/src/yemot-handler.service.ts @@ -13,7 +13,7 @@ import { ReportGroup } from './db/entities/ReportGroup.entity'; import { ReportGroupSession } from './db/entities/ReportGroupSession.entity'; import { LessonSchedule } from './db/entities/LessonSchedule.entity'; import { Lesson } from './db/entities/Lesson.entity'; -import { Between, In } from 'typeorm'; +import { Between, In, Like } from 'typeorm'; const SCHEDULE_MATCH_TOLERANCE_MINUTES = 90; /** @@ -435,6 +435,17 @@ export class YemotHandlerService extends BaseYemotHandlerService { await this.hangupWithMessageByKey('STUDENT.NO_CLASS'); return; } + // Transport lateness belongs to the student's morning klass ("בוקר ...") when she has one + const studentKlasses = await this.dataSource.getRepository(StudentKlass).findBy({ + userId: this.user.id, + studentReferenceId: student.id, + year: getCurrentHebrewYear(), + }); + const morningKlass = await this.dataSource.getRepository(Klass).findOneBy({ + userId: this.user.id, + id: In(studentKlasses.map((sk) => sk.klassReferenceId)), + name: Like('בוקר%'), + }); const newAbsence = absenceRepo.create({ userId: this.user.id, studentTz: student.tz, @@ -443,7 +454,7 @@ export class YemotHandlerService extends BaseYemotHandlerService { absnceCount: 1, isApproved: true, comment: `איחור של הסעה ${transportation.key}`, - klassReferenceId: studentKlass.klassReferenceId, + klassReferenceId: morningKlass?.id ?? studentKlass.klassReferenceId, }); await absenceRepo.save(newAbsence); } From 89a64417ec44b93ff5968674b44f14f75f0e8a55 Mon Sep 17 00:00:00 2001 From: Claude Date: Sun, 11 Oct 2026 20:41:33 +0000 Subject: [PATCH 2/2] refactor(yemot): fetch student klasses once in transport lateness flow Co-Authored-By: Claude Opus 5.5 Claude-Session: https://claude.ai/code/session_01Rubw4xHpfDfDmWWoZSQovN --- server/src/yemot-handler.service.ts | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/server/src/yemot-handler.service.ts b/server/src/yemot-handler.service.ts index 44900696..eb25cc42 100644 --- a/server/src/yemot-handler.service.ts +++ b/server/src/yemot-handler.service.ts @@ -427,23 +427,19 @@ export class YemotHandlerService extends BaseYemotHandlerService { private async createAbsenceRecord(student: Student, transportation: Transportation) { const absenceRepo = this.dataSource.getRepository(KnownAbsence); - const studentKlass = await this.dataSource.getRepository(StudentKlass).findOneBy({ + const studentKlasses = await this.dataSource.getRepository(StudentKlass).findBy({ userId: this.user.id, studentReferenceId: student.id, }); - if (!studentKlass) { + if (!studentKlasses.length) { await this.hangupWithMessageByKey('STUDENT.NO_CLASS'); return; } // Transport lateness belongs to the student's morning klass ("בוקר ...") when she has one - const studentKlasses = await this.dataSource.getRepository(StudentKlass).findBy({ - userId: this.user.id, - studentReferenceId: student.id, - year: getCurrentHebrewYear(), - }); const morningKlass = await this.dataSource.getRepository(Klass).findOneBy({ userId: this.user.id, id: In(studentKlasses.map((sk) => sk.klassReferenceId)), + year: getCurrentHebrewYear(), name: Like('בוקר%'), }); const newAbsence = absenceRepo.create({ @@ -454,7 +450,7 @@ export class YemotHandlerService extends BaseYemotHandlerService { absnceCount: 1, isApproved: true, comment: `איחור של הסעה ${transportation.key}`, - klassReferenceId: morningKlass?.id ?? studentKlass.klassReferenceId, + klassReferenceId: morningKlass?.id ?? studentKlasses[0].klassReferenceId, }); await absenceRepo.save(newAbsence); }