diff --git a/.github/skills/yemot-integration/SKILL.md b/.github/skills/yemot-integration/SKILL.md index 6727fd47..517e16c1 100644 --- a/.github/skills/yemot-integration/SKILL.md +++ b/.github/skills/yemot-integration/SKILL.md @@ -14,7 +14,8 @@ description: Use when working on Yemot (Israeli IVR phone) call flows in any NRA Shared code lives in `server/shared/utils/yemot/` (`nra-server`); each project subclasses it. - **v2 (current) — subclass `BaseYemotHandlerService`.** Each project defines `server/src/yemot-handler.service.ts` extending it and overriding `processCall()`. Inside, `this.call`, `this.user`, `this.logger` are available; branch on `hasPermission(this.user, '')` to route to the right flow. See `react-admin-nestjs/server/src/yemot-handler.service.ts`. -- The shared router/service (`v2/yemot-router.service.ts`, `yemot.service.ts`) owns call lifecycle: active-call map, step saving, hangup handling, `getUserByDidPhone()`. +- The shared router (`v2/yemot-router.service.ts`) and call tracker (`v2/yemot-call-tracking.service.ts`) own call lifecycle: active-call map, step saving, hangup handling, `getUserByDidPhone()`. +- **v1 (old chain-based `YemotModule`/`YemotService`/`Chain`) — removed from `nra-server`, do not reintroduce.** `yemot.interface.ts` now holds only `FormatString`. All phone code goes through v2. - **Permissions:** phone flows are gated by permission keys (e.g. `seminarAttendanceYemot`, `yemotSimulator`). Adding/gating a flow → also use `manage-permissions`. ## Common tasks @@ -23,7 +24,7 @@ Shared code lives in `server/shared/utils/yemot/` (`nra-server`); each project s **Menu texts** live in DB (`YemotCall`/yemot-texts) and are updated via migrations — see the `UpdateYemotTexts*` migrations in `react-admin-nestjs/server/src/migrations/`. Use `generate-migration` for schema/text changes. -**File upload/download to Yemot:** paths must carry the `ivr2:` scheme prefix (a past bug shipped without it). `deleteFile`/`downloadFile` live in the shared yemot util — reuse them, mind the auth and path prefix. +**File upload/download to Yemot:** paths must carry the `ivr2:` scheme prefix (a past bug shipped without it). `uploadFile`/`downloadFile`/`deleteFile` live in `utils/phone/yemot-api.service.ts` — reuse them, mind the auth and path prefix. ## Test with the scenario harness (no live phone) diff --git a/server/shared b/server/shared index 946441b7..b4080577 160000 --- a/server/shared +++ b/server/shared @@ -1 +1 @@ -Subproject commit 946441b7e9aca0ea7f483428ef5108259dc49c71 +Subproject commit b4080577c729d15ec16ce8ca68dec5e7b18a5e16