diff --git a/server/src/db/entities/AttReport.entity.ts b/server/src/db/entities/AttReport.entity.ts index e3f95074..97563a2d 100644 --- a/server/src/db/entities/AttReport.entity.ts +++ b/server/src/db/entities/AttReport.entity.ts @@ -111,10 +111,14 @@ export class AttReport implements IHasUserId { @Column('varchar', { name: 'student_tz', length: 10, nullable: true }) studentTz: string; - @ValidateIf((attReport: AttReport) => !Boolean(attReport.studentTz) && Boolean(attReport.studentReferenceId), { - always: true, - }) + @ValidateIf( + (attReport: AttReport) => attReport.studentReferenceId !== undefined && attReport.studentReferenceId !== null, + { + always: true, + }, + ) @IsNotEmpty({ groups: [CrudValidationGroups.CREATE] }) + @IsNumber({ maxDecimalPlaces: 0 }, { always: true }) @Column({ nullable: true }) @Index('att_reports_student_reference_id_idx') studentReferenceId: number; @@ -125,10 +129,14 @@ export class AttReport implements IHasUserId { @Column('varchar', { name: 'teacher_id', length: 10, nullable: true }) teacherId: string; - @ValidateIf((attReport: AttReport) => !Boolean(attReport.teacherId) && Boolean(attReport.teacherReferenceId), { - always: true, - }) + @ValidateIf( + (attReport: AttReport) => attReport.teacherReferenceId !== undefined && attReport.teacherReferenceId !== null, + { + always: true, + }, + ) @IsNotEmpty({ groups: [CrudValidationGroups.CREATE] }) + @IsNumber({ maxDecimalPlaces: 0 }, { always: true }) @Column({ nullable: true }) @Index('att_reports_teacher_reference_id_idx') teacherReferenceId: number; @@ -141,10 +149,14 @@ export class AttReport implements IHasUserId { @Column('int', { name: 'klass_id', nullable: true }) klassId: number | null; - @ValidateIf((attReport: AttReport) => !Boolean(attReport.klassId) && Boolean(attReport.klassReferenceId), { - always: true, - }) + @ValidateIf( + (attReport: AttReport) => attReport.klassReferenceId !== undefined && attReport.klassReferenceId !== null, + { + always: true, + }, + ) @IsNotEmpty({ groups: [CrudValidationGroups.CREATE] }) + @IsNumber({ maxDecimalPlaces: 0 }, { always: true }) @Column({ nullable: true }) @Index('att_reports_klass_reference_id_idx') klassReferenceId: number; @@ -156,9 +168,13 @@ export class AttReport implements IHasUserId { @Column('int', { name: 'lesson_id', nullable: true }) lessonId: number; - @ValidateIf((attReport: AttReport) => !Boolean(attReport.lessonId) && Boolean(attReport.lessonReferenceId), { - always: true, - }) + @ValidateIf( + (attReport: AttReport) => attReport.lessonReferenceId !== undefined && attReport.lessonReferenceId !== null, + { + always: true, + }, + ) + @IsNumber({ maxDecimalPlaces: 0 }, { always: true }) @Column({ nullable: true }) @Index('att_reports_lesson_reference_id_idx') lessonReferenceId: number; @@ -232,6 +248,8 @@ export class AttReport implements IHasUserId { @JoinColumn({ name: 'klassReferenceId' }) klass: Klass; + @IsOptional({ always: true }) + @IsNumber({ maxDecimalPlaces: 0 }, { always: true }) @Column({ nullable: true }) @Index('att_reports_report_group_session_id_idx') reportGroupSessionId: number; diff --git a/server/src/db/entities/AttendanceCleanupRule.entity.ts b/server/src/db/entities/AttendanceCleanupRule.entity.ts index 15d6789f..a849c5c5 100644 --- a/server/src/db/entities/AttendanceCleanupRule.entity.ts +++ b/server/src/db/entities/AttendanceCleanupRule.entity.ts @@ -72,6 +72,7 @@ export class AttendanceCleanupRule implements IHasUserId { @IsNotEmpty({ groups: [CrudValidationGroups.CREATE] }) @IsOptional({ groups: [CrudValidationGroups.UPDATE] }) + @IsNumber({ maxDecimalPlaces: 0 }, { always: true }) @Column({ nullable: true }) lessonReferenceId: number; @@ -85,6 +86,7 @@ export class AttendanceCleanupRule implements IHasUserId { /** The track/class to PRESERVE (checked via student_klasses membership, not att_reports.klassReferenceId). */ @IsNotEmpty({ groups: [CrudValidationGroups.CREATE] }) @IsOptional({ groups: [CrudValidationGroups.UPDATE] }) + @IsNumber({ maxDecimalPlaces: 0 }, { always: true }) @Column({ nullable: true }) klassReferenceId: number; diff --git a/server/src/db/entities/Grade.entity.ts b/server/src/db/entities/Grade.entity.ts index 87f41661..3a8f5e2f 100644 --- a/server/src/db/entities/Grade.entity.ts +++ b/server/src/db/entities/Grade.entity.ts @@ -103,8 +103,11 @@ export class Grade implements IHasUserId { @Column('varchar', { name: 'student_tz', length: 10, nullable: true }) studentTz: string; - @ValidateIf((grade: Grade) => !Boolean(grade.studentTz) && Boolean(grade.studentReferenceId), { always: true }) + @ValidateIf((grade: Grade) => grade.studentReferenceId !== undefined && grade.studentReferenceId !== null, { + always: true, + }) @IsNotEmpty({ groups: [CrudValidationGroups.CREATE] }) + @IsNumber({ maxDecimalPlaces: 0 }, { always: true }) @Column({ nullable: true }) @Index('grades_student_reference_id_idx') studentReferenceId: number; @@ -115,8 +118,11 @@ export class Grade implements IHasUserId { @Column('varchar', { name: 'teacher_id', length: 10, nullable: true }) teacherId: string; - @ValidateIf((grade: Grade) => !Boolean(grade.teacherId) && Boolean(grade.teacherReferenceId), { always: true }) + @ValidateIf((grade: Grade) => grade.teacherReferenceId !== undefined && grade.teacherReferenceId !== null, { + always: true, + }) @IsNotEmpty({ groups: [CrudValidationGroups.CREATE] }) + @IsNumber({ maxDecimalPlaces: 0 }, { always: true }) @Column({ nullable: true }) @Index('grades_teacher_reference_id_idx') teacherReferenceId: number; @@ -129,8 +135,11 @@ export class Grade implements IHasUserId { @Column('int', { name: 'klass_id', nullable: true }) klassId: number | null; - @ValidateIf((grade: Grade) => !Boolean(grade.klassId) && Boolean(grade.klassReferenceId), { always: true }) + @ValidateIf((grade: Grade) => grade.klassReferenceId !== undefined && grade.klassReferenceId !== null, { + always: true, + }) @IsNotEmpty({ groups: [CrudValidationGroups.CREATE] }) + @IsNumber({ maxDecimalPlaces: 0 }, { always: true }) @Column({ nullable: true }) @Index('grades_klass_reference_id_idx') klassReferenceId: number; @@ -142,7 +151,10 @@ export class Grade implements IHasUserId { @Column('int', { name: 'lesson_id', nullable: true }) lessonId: number; - @ValidateIf((grade: Grade) => !Boolean(grade.lessonId) && Boolean(grade.lessonReferenceId), { always: true }) + @ValidateIf((grade: Grade) => grade.lessonReferenceId !== undefined && grade.lessonReferenceId !== null, { + always: true, + }) + @IsNumber({ maxDecimalPlaces: 0 }, { always: true }) @Column({ nullable: true }) @Index('grades_lesson_reference_id_idx') lessonReferenceId: number; @@ -215,6 +227,8 @@ export class Grade implements IHasUserId { @JoinColumn({ name: 'klassReferenceId' }) klass: Klass; + @IsOptional({ always: true }) + @IsNumber({ maxDecimalPlaces: 0 }, { always: true }) @Column({ nullable: true }) @Index('grades_report_group_session_id_idx') reportGroupSessionId: number; diff --git a/server/src/db/entities/GradeName.entity.ts b/server/src/db/entities/GradeName.entity.ts index acf93bb3..56391c7d 100644 --- a/server/src/db/entities/GradeName.entity.ts +++ b/server/src/db/entities/GradeName.entity.ts @@ -59,6 +59,7 @@ export class GradeName implements IHasUserId { klassTypeId: number | null; @IsOptional({ always: true }) + @IsNumber({ maxDecimalPlaces: 0 }, { always: true }) @Column({ nullable: true }) @Index('grade_names_klass_type_reference_id_idx') klassTypeReferenceId: number; diff --git a/server/src/db/entities/Klass.entity.ts b/server/src/db/entities/Klass.entity.ts index c0b4c46e..2644668d 100644 --- a/server/src/db/entities/Klass.entity.ts +++ b/server/src/db/entities/Klass.entity.ts @@ -99,10 +99,14 @@ export class Klass implements IHasUserId { @Column('int', { name: 'klass_type_id', nullable: true }) klassTypeId: number | null; - @ValidateIf((attReport: Klass) => !Boolean(attReport.klassTypeId) && Boolean(attReport.klassTypeReferenceId), { - always: true, - }) + @ValidateIf( + (attReport: Klass) => attReport.klassTypeReferenceId !== undefined && attReport.klassTypeReferenceId !== null, + { + always: true, + }, + ) @IsNotEmpty({ groups: [CrudValidationGroups.CREATE] }) + @IsNumber({ maxDecimalPlaces: 0 }, { always: true }) @Column({ nullable: true }) @Index('klasses_klass_type_reference_id_idx') klassTypeReferenceId: number; @@ -118,6 +122,8 @@ export class Klass implements IHasUserId { @Column('varchar', { name: 'phone', nullable: true, length: 20 }) phone: string | null; + @IsOptional({ always: true }) + @IsNumber({ maxDecimalPlaces: 0 }, { always: true }) @Column({ nullable: true }) @Index('klasses_teacher_reference_id_idx') teacherReferenceId: number; diff --git a/server/src/db/entities/KlassType.entity.ts b/server/src/db/entities/KlassType.entity.ts index 4dcd16d7..492e94d5 100644 --- a/server/src/db/entities/KlassType.entity.ts +++ b/server/src/db/entities/KlassType.entity.ts @@ -77,6 +77,8 @@ export class KlassType implements IHasUserId { @Column('varchar', { name: 'teacher_id', length: 10, nullable: true }) teacherId: string; + @IsOptional({ always: true }) + @IsNumber({ maxDecimalPlaces: 0 }, { always: true }) @Column({ nullable: true }) teacherReferenceId: number; diff --git a/server/src/db/entities/KnownAbsence.entity.ts b/server/src/db/entities/KnownAbsence.entity.ts index 650017ae..a1697497 100644 --- a/server/src/db/entities/KnownAbsence.entity.ts +++ b/server/src/db/entities/KnownAbsence.entity.ts @@ -99,10 +99,14 @@ export class KnownAbsence implements IHasUserId { @Column('varchar', { name: 'student_tz', length: 10, nullable: true }) studentTz: string; - @ValidateIf((attReport: KnownAbsence) => !Boolean(attReport.studentTz) && Boolean(attReport.studentReferenceId), { - always: true, - }) + @ValidateIf( + (attReport: KnownAbsence) => attReport.studentReferenceId !== undefined && attReport.studentReferenceId !== null, + { + always: true, + }, + ) @IsNotEmpty({ groups: [CrudValidationGroups.CREATE] }) + @IsNumber({ maxDecimalPlaces: 0 }, { always: true }) @Column({ nullable: true }) @Index('known_absences_student_reference_id_idx') studentReferenceId: number; @@ -115,10 +119,14 @@ export class KnownAbsence implements IHasUserId { @Column('int', { name: 'klass_id', nullable: true }) klassId: number | null; - @ValidateIf((attReport: KnownAbsence) => !Boolean(attReport.klassId) && Boolean(attReport.klassReferenceId), { - always: true, - }) + @ValidateIf( + (attReport: KnownAbsence) => attReport.klassReferenceId !== undefined && attReport.klassReferenceId !== null, + { + always: true, + }, + ) @IsNotEmpty({ groups: [CrudValidationGroups.CREATE] }) + @IsNumber({ maxDecimalPlaces: 0 }, { always: true }) @Column({ nullable: true }) klassReferenceId: number; @@ -129,6 +137,7 @@ export class KnownAbsence implements IHasUserId { lessonId: number; @IsOptional({ always: true }) + @IsNumber({ maxDecimalPlaces: 0 }, { always: true }) @Column({ nullable: true }) lessonReferenceId: number; diff --git a/server/src/db/entities/Lesson.entity.ts b/server/src/db/entities/Lesson.entity.ts index 79f9437e..41bdad14 100644 --- a/server/src/db/entities/Lesson.entity.ts +++ b/server/src/db/entities/Lesson.entity.ts @@ -133,6 +133,8 @@ export class Lesson implements IHasUserId { @Column('varchar', { name: 'teacher_id', length: 10, nullable: true }) teacherId: string; + @IsOptional({ always: true }) + @IsNumber({ maxDecimalPlaces: 0 }, { always: true }) @Column({ nullable: true }) @Index('lessons_teacher_reference_id_idx') teacherReferenceId: number; diff --git a/server/src/db/entities/LessonSchedule.entity.ts b/server/src/db/entities/LessonSchedule.entity.ts index 052a435a..3669c8e5 100644 --- a/server/src/db/entities/LessonSchedule.entity.ts +++ b/server/src/db/entities/LessonSchedule.entity.ts @@ -107,10 +107,14 @@ export class LessonSchedule implements IHasUserId { klassId: number | null; @ValidateIf( - (lessonSchedule: LessonSchedule) => !Boolean(lessonSchedule.klassId) && Boolean(lessonSchedule.klassReferenceId), - { always: true }, + (lessonSchedule: LessonSchedule) => + lessonSchedule.klassReferenceId !== undefined && lessonSchedule.klassReferenceId !== null, + { + always: true, + }, ) @IsNotEmpty({ groups: [CrudValidationGroups.CREATE] }) + @IsNumber({ maxDecimalPlaces: 0 }, { always: true }) @Column({ nullable: true }) @Index('lesson_schedules_klass_reference_id_idx') klassReferenceId: number; @@ -125,10 +129,13 @@ export class LessonSchedule implements IHasUserId { @ValidateIf( (lessonSchedule: LessonSchedule) => - !Boolean(lessonSchedule.lessonId) && Boolean(lessonSchedule.lessonReferenceId), - { always: true }, + lessonSchedule.lessonReferenceId !== undefined && lessonSchedule.lessonReferenceId !== null, + { + always: true, + }, ) @IsNotEmpty({ groups: [CrudValidationGroups.CREATE] }) + @IsNumber({ maxDecimalPlaces: 0 }, { always: true }) @Column({ nullable: true }) @Index('lesson_schedules_lesson_reference_id_idx') lessonReferenceId: number; @@ -147,10 +154,13 @@ export class LessonSchedule implements IHasUserId { @ValidateIf( (lessonSchedule: LessonSchedule) => - !Boolean(lessonSchedule.teacherId) && Boolean(lessonSchedule.teacherReferenceId), - { always: true }, + lessonSchedule.teacherReferenceId !== undefined && lessonSchedule.teacherReferenceId !== null, + { + always: true, + }, ) @IsNotEmpty({ groups: [CrudValidationGroups.CREATE] }) + @IsNumber({ maxDecimalPlaces: 0 }, { always: true }) @Column({ nullable: true }) @Index('lesson_schedules_teacher_reference_id_idx') teacherReferenceId: number; diff --git a/server/src/db/entities/Student.entity.ts b/server/src/db/entities/Student.entity.ts index f1434cae..681a859c 100644 --- a/server/src/db/entities/Student.entity.ts +++ b/server/src/db/entities/Student.entity.ts @@ -3,7 +3,7 @@ import { IHasUserId } from '@shared/base-entity/interface'; import { User } from 'src/db/entities/User.entity'; import { IsOptional } from 'class-validator'; import { CrudValidationGroups } from '@dataui/crud'; -import { IsNotEmpty, IsUniqueCombination, MaxLength, IsBoolean, IsDigitsOnly } from '@shared/utils/validation/class-validator-he'; +import { IsNotEmpty, IsUniqueCombination, MaxLength, IsBoolean, IsDigitsOnly, IsNumber } from '@shared/utils/validation/class-validator-he'; import { StringType, BooleanType } from '@shared/utils/entity/class-transformer'; import { CreatedAtColumn, UpdatedAtColumn } from '@shared/utils/entity/column-types.util'; @@ -18,6 +18,8 @@ export class Student implements IHasUserId { @Column('int', { name: 'user_id' }) userId: number; + @IsOptional({ always: true }) + @IsNumber({ maxDecimalPlaces: 0 }, { always: true }) @Column({ nullable: true }) year: number; diff --git a/server/src/db/entities/StudentKlass.entity.ts b/server/src/db/entities/StudentKlass.entity.ts index 5b3455c9..901b78fa 100644 --- a/server/src/db/entities/StudentKlass.entity.ts +++ b/server/src/db/entities/StudentKlass.entity.ts @@ -112,10 +112,14 @@ export class StudentKlass implements IHasUserId { @Column('varchar', { name: 'student_tz', length: 10, nullable: true }) studentTz: string; - @ValidateIf((attReport: StudentKlass) => !Boolean(attReport.studentTz) && Boolean(attReport.studentReferenceId), { - always: true, - }) + @ValidateIf( + (attReport: StudentKlass) => attReport.studentReferenceId !== undefined && attReport.studentReferenceId !== null, + { + always: true, + }, + ) @IsNotEmpty({ groups: [CrudValidationGroups.CREATE] }) + @IsNumber({ maxDecimalPlaces: 0 }, { always: true }) @Column({ nullable: true }) studentReferenceId: number; @@ -127,10 +131,14 @@ export class StudentKlass implements IHasUserId { @Column('int', { name: 'klass_id', nullable: true }) klassId: number; - @ValidateIf((attReport: StudentKlass) => !Boolean(attReport.klassId) && Boolean(attReport.klassReferenceId), { - always: true, - }) + @ValidateIf( + (attReport: StudentKlass) => attReport.klassReferenceId !== undefined && attReport.klassReferenceId !== null, + { + always: true, + }, + ) @IsNotEmpty({ groups: [CrudValidationGroups.CREATE] }) + @IsNumber({ maxDecimalPlaces: 0 }, { always: true }) @Column({ nullable: true }) klassReferenceId: number; diff --git a/server/src/entity-modules/__tests__/numeric-referenceid-validation.spec.ts b/server/src/entity-modules/__tests__/numeric-referenceid-validation.spec.ts new file mode 100644 index 00000000..919d1a31 --- /dev/null +++ b/server/src/entity-modules/__tests__/numeric-referenceid-validation.spec.ts @@ -0,0 +1,142 @@ +import 'reflect-metadata'; +import { plainToInstance } from 'class-transformer'; +import { validate, ValidationError } from 'class-validator'; +import { CrudValidationGroups } from '@dataui/crud'; +import { Grade } from 'src/db/entities/Grade.entity'; +import { Student } from 'src/db/entities/Student.entity'; +import { AttReport } from 'src/db/entities/AttReport.entity'; +import { AttendanceCleanupRule } from 'src/db/entities/AttendanceCleanupRule.entity'; +import { StudentKlass } from 'src/db/entities/StudentKlass.entity'; +import { KnownAbsence } from 'src/db/entities/KnownAbsence.entity'; +import { Lesson } from 'src/db/entities/Lesson.entity'; +import { LessonSchedule } from 'src/db/entities/LessonSchedule.entity'; +import { Klass } from 'src/db/entities/Klass.entity'; +import { KlassType } from 'src/db/entities/KlassType.entity'; +import { GradeName } from 'src/db/entities/GradeName.entity'; + +/** + * Mirrors the CRUD validation pipeline (@dataui/crud ValidationPipe + + * validateBulk): plainToInstance applies the @Transform/@NumberType + * coercion, class-validator then runs with the CREATE/UPDATE group. + */ +const validateAs = async (entity: any, body: any, group: CrudValidationGroups): Promise => { + const instance = plainToInstance(entity, body); + return validate(instance, { groups: [group] }); +}; + +const errorProps = (errors: ValidationError[]): string[] => errors.map((e) => e.property); + +const errorsOnField = (errors: ValidationError[], field: string): boolean => + errors.some((e) => e.property === field && Boolean(e.constraints)); + +/** + * Every numeric ReferenceId/int column that previously let a non-numeric + * string through class-validator and crash at the MySQL INT column + * (extension of PR #186 / PR #188 to the remaining entities). + */ +const numericFields: Array<{ entity: any; field: string }> = [ + { entity: Grade, field: 'studentReferenceId' }, + { entity: Grade, field: 'teacherReferenceId' }, + { entity: Grade, field: 'klassReferenceId' }, + { entity: Grade, field: 'lessonReferenceId' }, + { entity: Grade, field: 'reportGroupSessionId' }, + { entity: AttReport, field: 'reportGroupSessionId' }, + { entity: AttendanceCleanupRule, field: 'lessonReferenceId' }, + { entity: AttendanceCleanupRule, field: 'klassReferenceId' }, + { entity: StudentKlass, field: 'studentReferenceId' }, + { entity: StudentKlass, field: 'klassReferenceId' }, + { entity: KnownAbsence, field: 'studentReferenceId' }, + { entity: KnownAbsence, field: 'lessonReferenceId' }, + { entity: Lesson, field: 'teacherReferenceId' }, + { entity: LessonSchedule, field: 'teacherReferenceId' }, + { entity: Klass, field: 'teacherReferenceId' }, + { entity: KlassType, field: 'teacherReferenceId' }, + { entity: Student, field: 'year' }, + { entity: KnownAbsence, field: 'klassReferenceId' }, + { entity: LessonSchedule, field: 'klassReferenceId' }, + { entity: LessonSchedule, field: 'lessonReferenceId' }, + { entity: Klass, field: 'klassTypeReferenceId' }, + { entity: GradeName, field: 'klassTypeReferenceId' }, +]; + +describe('numeric validation on ReferenceId/int columns', () => { + describe.each(numericFields)('$entity.name.$field', ({ entity, field }) => { + it('rejects a non-numeric string on create', async () => { + const errors = await validateAs(entity, { [field]: 'not-a-number' }, CrudValidationGroups.CREATE); + expect(errorsOnField(errors, field)).toBe(true); + }); + + it('rejects a non-numeric string on update', async () => { + const errors = await validateAs(entity, { [field]: 'not-a-number' }, CrudValidationGroups.UPDATE); + expect(errorsOnField(errors, field)).toBe(true); + }); + + it('accepts a valid integer on create and update', async () => { + const createErrors = await validateAs(entity, { [field]: 42 }, CrudValidationGroups.CREATE); + expect(errorsOnField(createErrors, field)).toBe(false); + const updateErrors = await validateAs(entity, { [field]: 42 }, CrudValidationGroups.UPDATE); + expect(errorsOnField(updateErrors, field)).toBe(false); + }); + + it('accepts a numeric string (coerced by NumberType) on create', async () => { + const errors = await validateAs(entity, { [field]: '42' }, CrudValidationGroups.CREATE); + expect(errorsOnField(errors, field)).toBe(false); + }); + + it('passes on a partial update that omits the field', async () => { + const errors = await validateAs(entity, {}, CrudValidationGroups.UPDATE); + expect(errorsOnField(errors, field)).toBe(false); + }); + }); + + describe('Grade create with only valid integers', () => { + it('passes validation cleanly', async () => { + const body = { + userId: 1, + reportDate: '2026-09-09', + studentReferenceId: 5, + teacherReferenceId: 6, + klassReferenceId: 7, + lessonReferenceId: 8, + reportGroupSessionId: 9, + grade: 90, + }; + const errors = await validateAs(Grade, body, CrudValidationGroups.CREATE); + expect(errorProps(errors)).toEqual([]); + }); + }); + + describe('Student create', () => { + it('passes without year (year stays optional)', async () => { + const body = { userId: 1, tz: '1234567890', name: 'test' }; + const errors = await validateAs(Student, body, CrudValidationGroups.CREATE); + expect(errorProps(errors)).toEqual([]); + }); + + it('passes with a valid year integer', async () => { + const body = { userId: 1, tz: '1234567890', name: 'test', year: 2026 }; + const errors = await validateAs(Student, body, CrudValidationGroups.CREATE); + expect(errorProps(errors)).toEqual([]); + }); + + it('rejects a non-numeric year', async () => { + const body = { userId: 1, tz: '1234567890', name: 'test', year: 'not-a-number' }; + const errors = await validateAs(Student, body, CrudValidationGroups.CREATE); + expect(errorProps(errors)).toEqual(['year']); + }); + }); + + describe('sibling-bypass regression: referenceId validated whenever present', () => { + it('Grade: rejects garbage studentReferenceId even when studentTz is also supplied', async () => { + const body = { studentTz: '1234567890', studentReferenceId: 'garbage', reportDate: '2026-09-16' }; + const errors = await validateAs(Grade, body, CrudValidationGroups.CREATE); + expect(errorsOnField(errors, 'studentReferenceId')).toBe(true); + }); + + it('AttReport: rejects garbage studentReferenceId even when studentTz is also supplied', async () => { + const body = { studentTz: '1234567890', studentReferenceId: 'garbage', reportDate: '2026-09-16' }; + const errors = await validateAs(AttReport, body, CrudValidationGroups.CREATE); + expect(errorsOnField(errors, 'studentReferenceId')).toBe(true); + }); + }); +});