From a07edce6acf5f468c4a53c6590511683d4fc1cd4 Mon Sep 17 00:00:00 2001 From: Claude Date: Tue, 18 Aug 2026 06:15:46 +0000 Subject: [PATCH] Rebuild scenario-step helpers on two generic primitives MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Replaces the ad-hoc per-flow helpers with a small tree: - ask()/askThenReject() are the only two functions that touch the YemotScenarioBuilder directly - every named step (respondToTz, askForKlass, confirmDeparture, etc.) is now a 1-line call into one of those two, parameterized by a named prompt-regex constant - reportAbsentStudent/rejectAbsentStudentName merged into a single confirmsStudentName(builder, num, accept) Net +7 lines (40 insertions / 33 deletions) — trades a few more small named functions for eliminating all regex/builder-call duplication; every step is now traceable to one of two primitives. Co-Authored-By: Claude Sonnet 5 Claude-Session: https://claude.ai/code/session_01MX2QnzzPvash7UmemgUPL9 --- server/src/yemot-handler.service.test.ts | 73 +++++++++++++----------- 1 file changed, 40 insertions(+), 33 deletions(-) diff --git a/server/src/yemot-handler.service.test.ts b/server/src/yemot-handler.service.test.ts index b6075671..2163a4fb 100644 --- a/server/src/yemot-handler.service.test.ts +++ b/server/src/yemot-handler.service.test.ts @@ -12,34 +12,55 @@ function israelTimeAt(hour: number, minute: number): Date { return new Date(utcMs); } -// ---- Reusable scenario-step helpers (each mutates and returns the same builder) ---- +// ---- Prompts reused across scenario steps ---- + +const TZ_PROMPT = /enter.*id/i; +const TRANSPORT_PROMPT = /transport/i; +const DEPARTURE_PROMPT = /departure.*07:30/i; +const KLASS_PROMPT = /enter klass number/i; +const ABSENT_STUDENT_PROMPT = /enter absent student number/i; +const CONFIRM_STUDENT_PROMPT = /confirm student/i; + +// ---- Generic scenario-step primitives — every step below is one of these ---- + +function ask(builder: YemotScenarioBuilder, prompt: RegExp, response: string): YemotScenarioBuilder { + return builder.systemAsks(prompt).userResponds(response); +} + +function askThenReject(builder: YemotScenarioBuilder, prompt: RegExp, response: string, errorMessage: RegExp): YemotScenarioBuilder { + return ask(builder, prompt, response).systemSends(errorMessage); +} + +// ---- Transport-call steps ---- function respondToTz(builder: YemotScenarioBuilder, tz: string): YemotScenarioBuilder { - return builder.systemAsks(/enter.*id/i).userResponds(tz); + return ask(builder, TZ_PROMPT, tz); } function rejectTz(builder: YemotScenarioBuilder, tz: string): YemotScenarioBuilder { - return builder.systemAsks(/enter.*id/i).userResponds(tz).systemSends(/not found|invalid/i); + return askThenReject(builder, TZ_PROMPT, tz, /not found|invalid/i); } function respondToTransport(builder: YemotScenarioBuilder, num: string): YemotScenarioBuilder { - return builder.systemAsks(/transport/i).userResponds(num); + return ask(builder, TRANSPORT_PROMPT, num); } function rejectTransport(builder: YemotScenarioBuilder, num: string): YemotScenarioBuilder { - return builder.systemAsks(/transport/i).userResponds(num).systemSends(/invalid|try again/i); + return askThenReject(builder, TRANSPORT_PROMPT, num, /invalid|try again/i); } function confirmDeparture(builder: YemotScenarioBuilder, confirm: boolean): YemotScenarioBuilder { - return builder.systemAsks(/departure.*07:30/i).userResponds(confirm ? '1' : '2'); + return ask(builder, DEPARTURE_PROMPT, confirm ? '1' : '2'); } +// ---- Seminar-attendance steps ---- + function askForKlass(builder: YemotScenarioBuilder, klassKey: string): YemotScenarioBuilder { - return builder.systemAsks(/enter klass number/i).userResponds(klassKey); + return ask(builder, KLASS_PROMPT, klassKey); } function rejectKlass(builder: YemotScenarioBuilder, klassKey: string): YemotScenarioBuilder { - return askForKlass(builder, klassKey).systemSends(/invalid klass/i); + return askThenReject(builder, KLASS_PROMPT, klassKey, /invalid klass/i); } function welcomesTeacher(builder: YemotScenarioBuilder): YemotScenarioBuilder { @@ -56,32 +77,18 @@ function startsSeminarCall(builder: YemotScenarioBuilder, klassKey: string): Yem return entersKlass(welcomesTeacher(builder), klassKey); } -function reportAbsentStudent(builder: YemotScenarioBuilder, studentNumber: string): YemotScenarioBuilder { - return builder - .systemAsks(/enter absent student number/i) - .userResponds(studentNumber) - .systemAsks(/confirm student/i) - .userResponds('1'); -} - -function rejectAbsentStudentName(builder: YemotScenarioBuilder, studentNumber: string): YemotScenarioBuilder { - return builder - .systemAsks(/enter absent student number/i) - .userResponds(studentNumber) - .systemAsks(/confirm student/i) - .userResponds('2') - .systemSends(/name rejected/i); +// Enters a student number, then answers the name-confirmation prompt yes/no. +function confirmsStudentName(builder: YemotScenarioBuilder, studentNumber: string, accept: boolean): YemotScenarioBuilder { + const answered = ask(ask(builder, ABSENT_STUDENT_PROMPT, studentNumber), CONFIRM_STUDENT_PROMPT, accept ? '1' : '2'); + return accept ? answered : answered.systemSends(/name rejected/i); } function rejectStudentNumber(builder: YemotScenarioBuilder, studentNumber: string): YemotScenarioBuilder { - return builder - .systemAsks(/enter absent student number/i) - .userResponds(studentNumber) - .systemSends(/invalid student number/i); + return askThenReject(builder, ABSENT_STUDENT_PROMPT, studentNumber, /invalid student number/i); } function finishAbsentStudentEntry(builder: YemotScenarioBuilder): YemotScenarioBuilder { - return builder.systemAsks(/enter absent student number/i).userResponds('0'); + return ask(builder, ABSENT_STUDENT_PROMPT, '0'); } describe('YemotHandlerService — react-admin-nestjs', () => { @@ -334,7 +341,7 @@ describe('YemotHandlerService — react-admin-nestjs', () => { .seed('ReportGroup', []) .seed('ReportGroupSession', []); startsSeminarCall(builder, '7'); - reportAbsentStudent(builder, '11'); + confirmsStudentName(builder, '11', true); finishAbsentStudentEntry(builder); const scenario = builder.systemHangsUp(/success/i).build(); @@ -371,7 +378,7 @@ describe('YemotHandlerService — react-admin-nestjs', () => { .seed('ReportGroup', []) .seed('ReportGroupSession', []); startsSeminarCall(builder, '8'); - reportAbsentStudent(builder, '11'); + confirmsStudentName(builder, '11', true); finishAbsentStudentEntry(builder); const scenario = builder.systemHangsUp(/success/i).build(); @@ -425,7 +432,7 @@ describe('YemotHandlerService — react-admin-nestjs', () => { const builder = seminarBuilder('Seminar invalid student number retry', klass); startsSeminarCall(builder, '10'); rejectStudentNumber(builder, '999'); - reportAbsentStudent(builder, '11'); + confirmsStudentName(builder, '11', true); finishAbsentStudentEntry(builder); const scenario = builder.systemHangsUp(/success/i).build(); @@ -440,8 +447,8 @@ describe('YemotHandlerService — react-admin-nestjs', () => { const builder = seminarBuilder('Seminar name confirmation rejected', klass).seed('AttReport', []); startsSeminarCall(builder, '15'); - rejectAbsentStudentName(builder, '11'); - reportAbsentStudent(builder, '12'); + confirmsStudentName(builder, '11', false); + confirmsStudentName(builder, '12', true); finishAbsentStudentEntry(builder); const scenario = builder.systemHangsUp(/success/i).build();