From 8ca0b70072749c9a9053d01fb6b6ecb05c191771 Mon Sep 17 00:00:00 2001 From: Claude Date: Mon, 17 Aug 2026 20:01:39 +0000 Subject: [PATCH 1/3] Bump server/shared to pick up academic year start change (Aug 1) Co-Authored-By: Claude Sonnet 5 Claude-Session: https://claude.ai/code/session_01MX2QnzzPvash7UmemgUPL9 --- server/shared | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/shared b/server/shared index c754a7f6..3a7a104e 160000 --- a/server/shared +++ b/server/shared @@ -1 +1 @@ -Subproject commit c754a7f672d540c37d79b7501410d02796b58276 +Subproject commit 3a7a104eee7dac4447bcf2429fd1e2f8983e675b From 99b22bcff7e45bdf8cf87d09b5e24471b7cf68e5 Mon Sep 17 00:00:00 2001 From: Claude Date: Tue, 18 Aug 2026 05:31:40 +0000 Subject: [PATCH 2/3] Add teacher welcome greeting and klass confirmation to seminar attendance call - Greets teacher by name at call start - Confirms klass name/number after manual klass entry - Fix howManyLessons staying null/0 on seminar attendance AttReport rows, breaking report calculations Co-Authored-By: Claude Sonnet 5 Claude-Session: https://claude.ai/code/session_01MX2QnzzPvash7UmemgUPL9 --- ...-UpdateYemotTextsWelcomeAndKlassConfirm.ts | 28 +++++++++++++++++++ server/src/yemot-handler.service.test.ts | 28 +++++++++++++++++++ server/src/yemot-handler.service.ts | 3 ++ 3 files changed, 59 insertions(+) create mode 100644 server/src/migrations/1787002860064-UpdateYemotTextsWelcomeAndKlassConfirm.ts diff --git a/server/src/migrations/1787002860064-UpdateYemotTextsWelcomeAndKlassConfirm.ts b/server/src/migrations/1787002860064-UpdateYemotTextsWelcomeAndKlassConfirm.ts new file mode 100644 index 00000000..bc57a5b0 --- /dev/null +++ b/server/src/migrations/1787002860064-UpdateYemotTextsWelcomeAndKlassConfirm.ts @@ -0,0 +1,28 @@ +import { MigrationInterface, QueryRunner } from "typeorm" + +export class UpdateYemotTextsWelcomeAndKlassConfirm1787002860064 implements MigrationInterface { + + public async up(queryRunner: QueryRunner): Promise { + const texts = [ + { name: 'SEMINAR.WELCOME', text: 'שלום המורה {teacherName}' }, + { name: 'SEMINAR.KLASS_CONFIRMED', text: 'כיתה {klassName}' }, + ]; + + for (const text of texts) { + await queryRunner.query( + 'INSERT INTO `texts` (`user_id`, `name`, `description`, `value`) VALUES (?, ?, ?, ?)', + [0, text.name, text.text, text.text], + ); + } + } + + public async down(queryRunner: QueryRunner): Promise { + await queryRunner.query( + 'DELETE FROM `texts` WHERE `user_id` = 0 AND `name` IN (?, ?)', + [ + 'SEMINAR.WELCOME', + 'SEMINAR.KLASS_CONFIRMED', + ], + ); + } +} diff --git a/server/src/yemot-handler.service.test.ts b/server/src/yemot-handler.service.test.ts index 91f6b9ac..55b10335 100644 --- a/server/src/yemot-handler.service.test.ts +++ b/server/src/yemot-handler.service.test.ts @@ -42,6 +42,14 @@ function rejectKlass(builder: YemotScenarioBuilder, klassKey: string): YemotScen return builder.systemAsks(/enter klass number/i).userResponds(klassKey).systemSends(/invalid klass/i); } +function welcomesTeacher(builder: YemotScenarioBuilder): YemotScenarioBuilder { + return builder.systemSends(/hello teacher/i); +} + +function confirmsKlass(builder: YemotScenarioBuilder): YemotScenarioBuilder { + return builder.systemSends(/confirmed klass/i); +} + function reportAbsentStudent(builder: YemotScenarioBuilder, studentNumber: string): YemotScenarioBuilder { return builder .systemAsks(/enter absent student number/i) @@ -274,6 +282,8 @@ describe('YemotHandlerService — react-admin-nestjs', () => { { userId: 0, name: 'SEMINAR.NO_STUDENTS_IN_KLASS', description: '', value: 'No students found for this klass' }, { userId: 0, name: 'SEMINAR.CONFIRM_STUDENT_NAME', description: '', value: 'Confirm student {studentName}' }, { userId: 0, name: 'SEMINAR.STUDENT_NAME_REJECTED', description: '', value: 'Name rejected, try again' }, + { userId: 0, name: 'SEMINAR.WELCOME', description: '', value: 'Hello teacher {teacherName}' }, + { userId: 0, name: 'SEMINAR.KLASS_CONFIRMED', description: '', value: 'Confirmed klass {klassName}' }, ]; const allTexts = [...baseTexts, ...seminarTexts]; @@ -305,7 +315,9 @@ describe('YemotHandlerService — react-admin-nestjs', () => { .seed('AttReport', []) .seed('ReportGroup', []) .seed('ReportGroupSession', []); + welcomesTeacher(builder); askForKlass(builder, '7'); + confirmsKlass(builder); reportAbsentStudent(builder, '11'); finishAbsentStudentEntry(builder); const scenario = builder.systemHangsUp(/success/i).build(); @@ -329,6 +341,7 @@ describe('YemotHandlerService — react-admin-nestjs', () => { expect(byStudent[103].absCount).toBe(0); for (const report of result.saved['AttReport']) { expect(report.reportGroupSessionId).toBe(session.id); + expect(report.howManyLessons).toBe(1); } }); @@ -347,7 +360,9 @@ describe('YemotHandlerService — react-admin-nestjs', () => { .seed('AttReport', []) .seed('ReportGroup', []) .seed('ReportGroupSession', []); + welcomesTeacher(builder); askForKlass(builder, '8'); + confirmsKlass(builder); reportAbsentStudent(builder, '11'); finishAbsentStudentEntry(builder); const scenario = builder.systemHangsUp(/success/i).build(); @@ -390,8 +405,10 @@ describe('YemotHandlerService — react-admin-nestjs', () => { .seed('Student', roster()) .seed('StudentKlass', studentKlasses(220, year)) .seed('Text', allTexts); + welcomesTeacher(builder); rejectKlass(builder, '99'); askForKlass(builder, '9'); + confirmsKlass(builder); finishAbsentStudentEntry(builder); const scenario = builder.systemHangsUp(/success/i).build(); @@ -411,7 +428,9 @@ describe('YemotHandlerService — react-admin-nestjs', () => { .seed('Student', roster()) .seed('StudentKlass', studentKlasses(230, year)) .seed('Text', allTexts); + welcomesTeacher(builder); askForKlass(builder, '10'); + confirmsKlass(builder); rejectStudentNumber(builder, '999'); reportAbsentStudent(builder, '11'); finishAbsentStudentEntry(builder); @@ -434,7 +453,9 @@ describe('YemotHandlerService — react-admin-nestjs', () => { .seed('StudentKlass', studentKlasses(235, year)) .seed('Text', allTexts) .seed('AttReport', []); + welcomesTeacher(builder); askForKlass(builder, '15'); + confirmsKlass(builder); rejectAbsentStudentName(builder, '11'); reportAbsentStudent(builder, '12'); finishAbsentStudentEntry(builder); @@ -464,7 +485,9 @@ describe('YemotHandlerService — react-admin-nestjs', () => { { id: 900, userId: 1, studentReferenceId: 101, klassReferenceId: 240, reportDate: today, absCount: 0 }, ]) .seed('Text', allTexts); + welcomesTeacher(builder); askForKlass(builder, '11'); + confirmsKlass(builder); const scenario = builder.systemHangsUp(/already reported/i).build(); const result = await runner.run(scenario); @@ -498,6 +521,7 @@ describe('YemotHandlerService — react-admin-nestjs', () => { .seed('StudentKlass', studentKlasses(260, year)) .seed('Text', allTexts) .seed('AttReport', []); + welcomesTeacher(builder); finishAbsentStudentEntry(builder); const scenario = builder.systemHangsUp(/success/i).build(); @@ -525,7 +549,9 @@ describe('YemotHandlerService — react-admin-nestjs', () => { .seed('StudentKlass', studentKlasses(270, year)) .seed('Text', allTexts) .seed('AttReport', []); + welcomesTeacher(builder); askForKlass(builder, '14'); + confirmsKlass(builder); finishAbsentStudentEntry(builder); const scenario = builder.systemHangsUp(/success/i).build(); @@ -549,7 +575,9 @@ describe('YemotHandlerService — react-admin-nestjs', () => { .seed('Teacher', [teacher]) .seed('Klass', [klass]) .seed('Text', allTexts); + welcomesTeacher(builder); askForKlass(builder, '12'); + confirmsKlass(builder); const scenario = builder.systemHangsUp(/no students/i).build(); const result = await runner.run(scenario); diff --git a/server/src/yemot-handler.service.ts b/server/src/yemot-handler.service.ts index 4f5dfff5..43a16f4b 100644 --- a/server/src/yemot-handler.service.ts +++ b/server/src/yemot-handler.service.ts @@ -100,6 +100,7 @@ export class YemotHandlerService extends BaseYemotHandlerService { private async processSeminarAttendanceCall(): Promise { const teacher = await this.getTeacherByPhone(); if (!teacher) return; + await this.sendMessageByKey('SEMINAR.WELCOME', { teacherName: teacher.name }); const schedule = await this.getScheduleForTeacherNow(teacher); let klass: Klass = null; @@ -191,6 +192,7 @@ export class YemotHandlerService extends BaseYemotHandlerService { await this.sendMessageByKey('SEMINAR.INVALID_KLASS'); } } + await this.sendMessageByKey('SEMINAR.KLASS_CONFIRMED', { klassName: klass.name }); return klass; } @@ -288,6 +290,7 @@ export class YemotHandlerService extends BaseYemotHandlerService { lessonReferenceId, reportGroupSessionId, reportDate, + howManyLessons: 1, absCount: absentStudentReferenceIds.has(studentKlass.studentReferenceId) ? 1 : 0, }), ); From 5e840bac353516603eb1c4852f42bfdf1c2df82b Mon Sep 17 00:00:00 2001 From: Claude Date: Tue, 18 Aug 2026 05:38:24 +0000 Subject: [PATCH 3/3] Dedupe repeated welcomesTeacher/askForKlass/confirmsKlass sequences in seminar tests Adds entersKlass() (klass entry + confirmation) and startsSeminarCall() (greeting + klass entry) helpers, replacing the same 2-3 line block that was repeated across most seminar-attendance test cases. Co-Authored-By: Claude Sonnet 5 Claude-Session: https://claude.ai/code/session_01MX2QnzzPvash7UmemgUPL9 --- server/src/yemot-handler.service.test.ts | 41 +++++++++--------------- 1 file changed, 16 insertions(+), 25 deletions(-) diff --git a/server/src/yemot-handler.service.test.ts b/server/src/yemot-handler.service.test.ts index 55b10335..b2dcb684 100644 --- a/server/src/yemot-handler.service.test.ts +++ b/server/src/yemot-handler.service.test.ts @@ -46,8 +46,14 @@ function welcomesTeacher(builder: YemotScenarioBuilder): YemotScenarioBuilder { return builder.systemSends(/hello teacher/i); } -function confirmsKlass(builder: YemotScenarioBuilder): YemotScenarioBuilder { - return builder.systemSends(/confirmed klass/i); +// Manual klass entry (askForKlass) followed by the system's spoken confirmation. +function entersKlass(builder: YemotScenarioBuilder, klassKey: string): YemotScenarioBuilder { + return askForKlass(builder, klassKey).systemSends(/confirmed klass/i); +} + +// Teacher greeting + manual klass entry — the common opening of a seminar call. +function startsSeminarCall(builder: YemotScenarioBuilder, klassKey: string): YemotScenarioBuilder { + return entersKlass(welcomesTeacher(builder), klassKey); } function reportAbsentStudent(builder: YemotScenarioBuilder, studentNumber: string): YemotScenarioBuilder { @@ -315,9 +321,7 @@ describe('YemotHandlerService — react-admin-nestjs', () => { .seed('AttReport', []) .seed('ReportGroup', []) .seed('ReportGroupSession', []); - welcomesTeacher(builder); - askForKlass(builder, '7'); - confirmsKlass(builder); + startsSeminarCall(builder, '7'); reportAbsentStudent(builder, '11'); finishAbsentStudentEntry(builder); const scenario = builder.systemHangsUp(/success/i).build(); @@ -360,9 +364,7 @@ describe('YemotHandlerService — react-admin-nestjs', () => { .seed('AttReport', []) .seed('ReportGroup', []) .seed('ReportGroupSession', []); - welcomesTeacher(builder); - askForKlass(builder, '8'); - confirmsKlass(builder); + startsSeminarCall(builder, '8'); reportAbsentStudent(builder, '11'); finishAbsentStudentEntry(builder); const scenario = builder.systemHangsUp(/success/i).build(); @@ -407,8 +409,7 @@ describe('YemotHandlerService — react-admin-nestjs', () => { .seed('Text', allTexts); welcomesTeacher(builder); rejectKlass(builder, '99'); - askForKlass(builder, '9'); - confirmsKlass(builder); + entersKlass(builder, '9'); finishAbsentStudentEntry(builder); const scenario = builder.systemHangsUp(/success/i).build(); @@ -428,9 +429,7 @@ describe('YemotHandlerService — react-admin-nestjs', () => { .seed('Student', roster()) .seed('StudentKlass', studentKlasses(230, year)) .seed('Text', allTexts); - welcomesTeacher(builder); - askForKlass(builder, '10'); - confirmsKlass(builder); + startsSeminarCall(builder, '10'); rejectStudentNumber(builder, '999'); reportAbsentStudent(builder, '11'); finishAbsentStudentEntry(builder); @@ -453,9 +452,7 @@ describe('YemotHandlerService — react-admin-nestjs', () => { .seed('StudentKlass', studentKlasses(235, year)) .seed('Text', allTexts) .seed('AttReport', []); - welcomesTeacher(builder); - askForKlass(builder, '15'); - confirmsKlass(builder); + startsSeminarCall(builder, '15'); rejectAbsentStudentName(builder, '11'); reportAbsentStudent(builder, '12'); finishAbsentStudentEntry(builder); @@ -485,9 +482,7 @@ describe('YemotHandlerService — react-admin-nestjs', () => { { id: 900, userId: 1, studentReferenceId: 101, klassReferenceId: 240, reportDate: today, absCount: 0 }, ]) .seed('Text', allTexts); - welcomesTeacher(builder); - askForKlass(builder, '11'); - confirmsKlass(builder); + startsSeminarCall(builder, '11'); const scenario = builder.systemHangsUp(/already reported/i).build(); const result = await runner.run(scenario); @@ -549,9 +544,7 @@ describe('YemotHandlerService — react-admin-nestjs', () => { .seed('StudentKlass', studentKlasses(270, year)) .seed('Text', allTexts) .seed('AttReport', []); - welcomesTeacher(builder); - askForKlass(builder, '14'); - confirmsKlass(builder); + startsSeminarCall(builder, '14'); finishAbsentStudentEntry(builder); const scenario = builder.systemHangsUp(/success/i).build(); @@ -575,9 +568,7 @@ describe('YemotHandlerService — react-admin-nestjs', () => { .seed('Teacher', [teacher]) .seed('Klass', [klass]) .seed('Text', allTexts); - welcomesTeacher(builder); - askForKlass(builder, '12'); - confirmsKlass(builder); + startsSeminarCall(builder, '12'); const scenario = builder.systemHangsUp(/no students/i).build(); const result = await runner.run(scenario);