Skip to content

[Classic] Localization confusion #114

Description

@rddim

I'm a little confused about the localization. In the https://github.com/builtbybel/FluentCleaner/blob/main/FluentCleaner.Classic/TRANSLATING_CLASSIC.md#add-your-translator-credit we have

{
  "_Meta_LanguageDisplayName": "Français",

and after that

_Meta_LanguageDisplayName is the English name shown in the language selector (for example, Bulgarian, not Български)

but in the example Français is in French, not in English. Also in the de.json it is Deutsch and not German. And also in the localization files we have "BasicSettings_LangEnglish": and "BasicSettings_LangGerman": but these strings do not appear anywhere, even if they have been translated. For me, as an ordinary user, it would be best if each language were displayed with its own translation, rather than in English.

Image

instead of

Image

If the purpose of "BasicSettings_LangEnglish": and "BasicSettings_LangGerman": is to display a translation in the respective language ("BasicSettings_LangEnglish": English, "BasicSettings_LangGerman": German), then the other languages should also be added, such as "BasicSettings_LangBulgarian": Bulgarian, etc. This, in turn, means that every translator would have to translate every newly added language, which would be tedious. In my opinion, the best option is to remove these strings and use only "_Meta_LanguageDisplayName": with Български, Deutsch, English, Ελληνικά, 简体中文 and etc. I suppose that would also save some extra code.

Metadata

Metadata

Assignees

No one assigned

    Labels

    documentationImprovements or additions to documentation

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions