I'm a little confused about the localization. In the https://github.com/builtbybel/FluentCleaner/blob/main/FluentCleaner.Classic/TRANSLATING_CLASSIC.md#add-your-translator-credit we have
{
"_Meta_LanguageDisplayName": "Français",
and after that
_Meta_LanguageDisplayName is the English name shown in the language selector (for example, Bulgarian, not Български)
but in the example Français is in French, not in English. Also in the de.json it is Deutsch and not German. And also in the localization files we have "BasicSettings_LangEnglish": and "BasicSettings_LangGerman": but these strings do not appear anywhere, even if they have been translated. For me, as an ordinary user, it would be best if each language were displayed with its own translation, rather than in English.
instead of
If the purpose of "BasicSettings_LangEnglish": and "BasicSettings_LangGerman": is to display a translation in the respective language ("BasicSettings_LangEnglish": English, "BasicSettings_LangGerman": German), then the other languages should also be added, such as "BasicSettings_LangBulgarian": Bulgarian, etc. This, in turn, means that every translator would have to translate every newly added language, which would be tedious. In my opinion, the best option is to remove these strings and use only "_Meta_LanguageDisplayName": with Български, Deutsch, English, Ελληνικά, 简体中文 and etc. I suppose that would also save some extra code.
I'm a little confused about the localization. In the https://github.com/builtbybel/FluentCleaner/blob/main/FluentCleaner.Classic/TRANSLATING_CLASSIC.md#add-your-translator-credit we have
{ "_Meta_LanguageDisplayName": "Français",and after that
but in the example
Françaisis in French, not in English. Also in thede.jsonit isDeutschand notGerman. And also in the localization files we have"BasicSettings_LangEnglish":and"BasicSettings_LangGerman":but these strings do not appear anywhere, even if they have been translated. For me, as an ordinary user, it would be best if each language were displayed with its own translation, rather than in English.instead of
If the purpose of
"BasicSettings_LangEnglish":and"BasicSettings_LangGerman":is to display a translation in the respective language ("BasicSettings_LangEnglish": English,"BasicSettings_LangGerman": German), then the other languages should also be added, such as"BasicSettings_LangBulgarian": Bulgarian, etc. This, in turn, means that every translator would have to translate every newly added language, which would be tedious. In my opinion, the best option is to remove these strings and use only"_Meta_LanguageDisplayName":withБългарски,Deutsch,English,Ελληνικά,简体中文and etc. I suppose that would also save some extra code.