ratio decimal point error

[kevin-dunas]

Hello, I am using your app well.
If you enter the ratio as a decimal point, there seems to be a bug.
If the ratio is 7.5 and 20g of coffee beans, the amount of water should be 150ml.
But in the app it comes out as 320ml.
If you have 320ml of water and 20g of coffee beans, the ratio should come out 16.
There seems to be an error in the process of handling decimal points. Can you please fix this?

[edwellbrook]

Hi @kevin-dunas,

Thanks for opening this issue. I would accept a pull request that fixes this.

Currently Ratios treats the "Ratio" input as an integer. You can see an example of this here:

Ratios/Ratios/Helpers/Calculator.swift

Line 13 in 6626421

static func calculateGrounds(brew: Double, ratio: Int) -> Double {

Ratios/Ratios/Helpers/PersistenceStore.swift

Line 28 in 6626421

let ratio = self.integer(forKey: UserDefaults.ratiosPersistenceRatioKey)

Ratios/Ratios/CalculatorViewController.swift

Line 160 in 6626421

let ratio = Int(self.ratioInputView.textField.text ?? "16") ?? 16

Please open a PR that changes Int to Double and I can merge and release the fix.

Thanks.