From 1367ef1f76a3810ad2bf7d1699d22579fa69ca7c Mon Sep 17 00:00:00 2001 From: kenny lopez Date: Wed, 5 Aug 2026 18:56:40 +0100 Subject: [PATCH 1/5] Polish advanced agent setup and Welcome composer Signed-off-by: kenny lopez --- .../agents/ui/AgentDefinitionDialog.tsx | 6 +- .../agents/ui/PersonaAdvancedFields.tsx | 5 ++ .../features/agents/ui/WhereToRunSection.tsx | 29 ++++--- .../src/features/channels/ui/ChannelPane.tsx | 18 ++--- .../channels/ui/WelcomeComposerBanner.tsx | 27 +++++++ .../messages/ui/ComposerDockBackdrop.tsx | 23 +++++- desktop/tests/e2e/onboarding.spec.ts | 75 ++++++++++++++++++- desktop/tests/e2e/where-to-run-config.spec.ts | 44 ++++++++++- 8 files changed, 197 insertions(+), 30 deletions(-) diff --git a/desktop/src/features/agents/ui/AgentDefinitionDialog.tsx b/desktop/src/features/agents/ui/AgentDefinitionDialog.tsx index 12702f45ac..b3f8ee86a7 100644 --- a/desktop/src/features/agents/ui/AgentDefinitionDialog.tsx +++ b/desktop/src/features/agents/ui/AgentDefinitionDialog.tsx @@ -109,7 +109,6 @@ type AgentDefinitionDialogProps = { ) => Promise; /** Publishes saved changes when the edited agent is shared in the catalog. */ publishCatalogUpdatesOnSave?: boolean; - /** Rendered below the form fields in create mode only ("Where to run"). */ createRunSection?: React.ReactNode; /** Extra create-mode submit gate (e.g. incomplete provider config). */ createSubmitBlocked?: boolean; @@ -963,8 +962,6 @@ export function AgentDefinitionDialog({ open={isAddHarnessOpen} /> - {isCreateMode ? createRunSection : null} -