diff --git a/desktop/src/features/agents/AGENTS.md b/desktop/src/features/agents/AGENTS.md index b929dbb613..b578326eba 100644 --- a/desktop/src/features/agents/AGENTS.md +++ b/desktop/src/features/agents/AGENTS.md @@ -113,13 +113,16 @@ with a TypeScript lookup table or an id comparison in a component. Once the Advanced toggle is visible, its expanded state is exclusively user-controlled: provider, harness, and required-env changes must never open it automatically in defaults, create, or edit flows. In Create mode, - the defaults summary follows preferred-harness changes saved while the - dialog is open, and its configured state includes required credentials as - well as provider/model values. If no available harness can resolve, Create - starts in Customize and lets unavailable catalog entries be selected only - to expose their setup guidance; submission remains blocked. - Advanced-only required credentials mark the collapsed Advanced toggle - without opening it in Global Defaults and Edit, and block incomplete saves. + `Run on` belongs in Advanced directly after **Who can send instructions**; + keep it out of the basic create fields. The defaults summary follows + preferred-harness changes saved while the dialog is open, and its configured + state includes required credentials as well as provider/model values. If no + available harness can resolve, Create starts in Customize and lets unavailable + catalog entries be selected only to expose their setup guidance; submission + remains blocked. + Advanced-only required credentials and incomplete remote **Run on** setup + mark the collapsed Advanced toggle without opening it, and block incomplete + saves. Runtime-file credentials satisfy Global Defaults just as they do Create and Edit. In Edit, selecting Custom command keeps its required command field beside the harness diff --git a/desktop/src/features/agents/ui/AgentDefinitionDialog.tsx b/desktop/src/features/agents/ui/AgentDefinitionDialog.tsx index 12702f45ac..409ae6a821 100644 --- a/desktop/src/features/agents/ui/AgentDefinitionDialog.tsx +++ b/desktop/src/features/agents/ui/AgentDefinitionDialog.tsx @@ -109,7 +109,6 @@ type AgentDefinitionDialogProps = { ) => Promise; /** Publishes saved changes when the edited agent is shared in the catalog. */ publishCatalogUpdatesOnSave?: boolean; - /** Rendered below the form fields in create mode only ("Where to run"). */ createRunSection?: React.ReactNode; /** Extra create-mode submit gate (e.g. incomplete provider config). */ createSubmitBlocked?: boolean; @@ -962,9 +961,6 @@ export function AgentDefinitionDialog({ onSaved={selectSavedHarness} open={isAddHarnessOpen} /> - - {isCreateMode ? createRunSection : null} -