Describe the enhancement
With the release of bdk_wallet v2.2.0, the signer module has been deprecated seemingly in favor of using the bitcoin::psbt::Psbt::sign method instead. I think this change generally makes sense. However, the Psbt::sign method takes in two params, one of which is something implementing the GetKey trait. There are a few structs that implement GetKey, none of which seem reasonably possible from bdk_wallet. There is an open PR #334, and I can use that code to create a key map. However, this KeyMap doesn't implement GetKey. In addition, the as_key_map method of the SignersContainer struct is also deprecated due to the signer module deprecation, meaning this won't be usable going forward either.
Perhaps I'm just missing something, and there's a good chance I am given this has been released for a month now and I don't see any issues about this. However, to prevent other users from having this issue, and as a way of helping me move forward as well, a simple example demonstrating this newer method of signing instead of using the Wallet::sign method would be very helpful.
Use case
I want to be able to create and sign transactions in whatever the recommended way is, which seems to not involve the signer module anymore.
Impact
Are you using BDK in a production project?
Which backend(s) are relevant (if any)?
Project or organization (optional)
Voltage
Describe the enhancement
With the release of bdk_wallet v2.2.0, the
signermodule has been deprecated seemingly in favor of using thebitcoin::psbt::Psbt::signmethod instead. I think this change generally makes sense. However, thePsbt::signmethod takes in two params, one of which is something implementing theGetKeytrait. There are a few structs that implementGetKey, none of which seem reasonably possible from bdk_wallet. There is an open PR #334, and I can use that code to create a key map. However, thisKeyMapdoesn't implementGetKey. In addition, theas_key_mapmethod of theSignersContainerstruct is also deprecated due to thesignermodule deprecation, meaning this won't be usable going forward either.Perhaps I'm just missing something, and there's a good chance I am given this has been released for a month now and I don't see any issues about this. However, to prevent other users from having this issue, and as a way of helping me move forward as well, a simple example demonstrating this newer method of signing instead of using the
Wallet::signmethod would be very helpful.Use case
I want to be able to create and sign transactions in whatever the recommended way is, which seems to not involve the
signermodule anymore.Impact
Are you using BDK in a production project?
Which backend(s) are relevant (if any)?
bdk_chain,bdk_core)____Project or organization (optional)
Voltage