fix(common): 修复日期时间戳解析溢出

Author: binarywang

weixin-java-common/src/main/java/me/chanjar/weixin/common/util/json/WxDateTypeAdapter.java

@@ -35,7 +35,12 @@ public Date read(JsonReader in) throws IOException {
         in.nextNull();
         return null;
       case NUMBER:
-        return new Date(in.nextInt() * 1000);
+        long seconds = in.nextLong();
+        try {
+          return new Date(Math.multiplyExact(seconds, 1000L));
+        } catch (ArithmeticException e) {
+          throw new JsonParseException("Timestamp seconds out of range: " + seconds, e);
+        }
       default:
         throw new JsonParseException("Expected NUMBER but was " + peek);
     }

weixin-java-common/src/test/java/me/chanjar/weixin/common/util/json/WxDateTypeAdapterTest.java

@@ -0,0 +1,47 @@
+package me.chanjar.weixin.common.util.json;
+
+import com.google.gson.JsonParseException;
+import org.testng.annotations.Test;
+
+import java.io.IOException;
+import java.util.Date;
+
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.assertThatThrownBy;
+
+/**
+ * Tests for {@link WxDateTypeAdapter}.
+ */
+public class WxDateTypeAdapterTest {
+  private final WxDateTypeAdapter adapter = new WxDateTypeAdapter();
+
+  @Test
+  public void testReadTimestampAfter2038() throws IOException {
+    Date date = this.adapter.fromJson("4102444800");
+
+    assertThat(date).isEqualTo(new Date(4102444800000L));
+  }
+
+  @Test
+  public void testReadRejectsPositiveMillisecondOverflow() {
+    long overflowingSeconds = Long.MAX_VALUE / 1000 + 1;
+
+    assertThatThrownBy(() -> this.adapter.fromJson(Long.toString(overflowingSeconds)))
+        .isInstanceOf(JsonParseException.class)
+        .hasMessageContaining("out of range");
+  }
+
+  @Test
+  public void testReadRejectsNegativeMillisecondOverflow() {
+    long overflowingSeconds = Long.MIN_VALUE / 1000 - 1;
+
+    assertThatThrownBy(() -> this.adapter.fromJson(Long.toString(overflowingSeconds)))
+        .isInstanceOf(JsonParseException.class)
+        .hasMessageContaining("out of range");
+  }
+
+  @Test
+  public void testWriteUsesSeconds() throws IOException {
+    assertThat(this.adapter.toJson(new Date(4102444800123L))).isEqualTo("4102444800");
+  }
+}

weixin-java-common/src/test/resources/testng.xml

@@ -7,6 +7,7 @@
       <class name="me.chanjar.weixin.common.error.WxErrorTest"/>
       <class name="me.chanjar.weixin.common.bean.WxMenuTest"/>
       <class name="me.chanjar.weixin.common.util.crypto.WxCryptUtilTest"/>
+      <class name="me.chanjar.weixin.common.util.json.WxDateTypeAdapterTest"/>
       <class name="me.chanjar.weixin.common.api.WxMessageInMemoryDuplicateCheckerTest"/>
       <class name="me.chanjar.weixin.common.session.SessionTest"/>
     </classes>