From a1ff4e512914077aae69cb257a7736ce11237be2 Mon Sep 17 00:00:00 2001 From: keshavprasadms Date: Tue, 23 Feb 2021 18:41:05 +0530 Subject: [PATCH 1/2] feat: adding PR template --- .github/pull_request_template.md | 34 ++++++++++++++++++++++++++++++++ 1 file changed, 34 insertions(+) create mode 100644 .github/pull_request_template.md diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md new file mode 100644 index 0000000000..b5daeaf200 --- /dev/null +++ b/.github/pull_request_template.md @@ -0,0 +1,34 @@ +Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. + +Fixes # (jira issue link) + +## Type of change + +Please delete options that are not relevant. + +- [ ] Bug fix (non-breaking change which fixes an issue) +- [ ] New feature (non-breaking change which adds functionality) +- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) +- [ ] This change requires a documentation update + +# How Has This Been Tested? + +Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration + +- [ ] Test A +- [ ] Test B + +**Test Configuration**: +* Software versions: +* Hardware versions: + +# Checklist: + +- [ ] My code follows the style guidelines of this project +- [ ] I have performed a self-review of my own code +- [ ] I have commented my code, particularly in hard-to-understand areas +- [ ] I have made corresponding changes to the documentation +- [ ] My changes generate no new warnings +- [ ] I have added tests that prove my fix is effective or that my feature works +- [ ] New and existing unit tests pass locally with my changes +- [ ] Any dependent changes have been merged and published in downstream modules From 200c548e7fb97d021114f78c80ebd162da03a38d Mon Sep 17 00:00:00 2001 From: keshavprasadms Date: Tue, 23 Feb 2021 18:42:11 +0530 Subject: [PATCH 2/2] fix: update code --- ansible-syntax-check.sh | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/ansible-syntax-check.sh b/ansible-syntax-check.sh index b09f9631d5..27bcaed6bd 100755 --- a/ansible-syntax-check.sh +++ b/ansible-syntax-check.sh @@ -11,9 +11,7 @@ if [ "$#" -ne 1 ]; then fi set -e - INVENTORY_DIR=$1 - for playbook_yaml in $SUNBIRD_DEVOPS_FOLDER/ansible/*.yml; do ansible-playbook -i $INVENTORY_DIR $playbook_yaml --syntax-check -e "hosts=dummy" -done \ No newline at end of file +done