windows 10, ld.lld: unknown -z value: separate-code; error: cannot open crtbegin_so.o; error: cannot open crtend_so.o

[wxfred]

$env:ANDROID_NDK_HOME="C:/Users/xxx/AppData/Local/Android/Sdk/ndk/21.0.6113669"
bazel build //:jni --cpu=arm64-v8a --crosstool_top=@androidndk//:toolchain

INFO: Analyzed target //:jni (39 packages loaded, 4184 targets configured).
INFO: Found 1 target...
ERROR: C:/xxx/bazelndktest-pure/BUILD:9:11: Linking libjni.so failed: (Exit 1): clang.exe failed: error executing command (from target //:jni) external\androidndk\toolchains\llvm\prebuilt\windows-x86_64\bin\clang.exe @bazel-out/arm64-v8a-fastbuild/bin/libjni.so-2.params
ld.lld: error: unknown -z value: separate-code
ld.lld: error: cannot open crtbegin_so.o: No such file or directory
ld.lld: error: cannot open crtend_so.o: No such file or directory
clang: error: linker command failed with exit code 1 (use -v to see invocation)
Target //:jni failed to build
Use --verbose_failures to see the command lines of failed build steps.
INFO: Elapsed time: 5.097s, Critical Path: 0.40s
INFO: 5 processes: 3 internal, 2 local.
FAILED: Build did NOT complete successfully

all my files:
BUILD

platform(
    name = "arm64-v8a",
    constraint_values = [
        "@platforms//cpu:arm64",
        "@platforms//os:android",
    ],
)

cc_library(
    name = "jni",
    srcs = ["jni.cc"],
)

jni.cc

#include <jni.h>
#include <stdio.h>

extern "C" JNIEXPORT int JNICALL
Java_com_app_Jni_getValue(JNIEnv *env, jclass clazz) {
    printf("hello world!");
    return 1;
}

WORKSPACE

load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")

http_archive(
    name = "rules_cc",
    sha256 = "abc605dd850f813bb37004b77db20106a19311a96b2da1c92b789da529d28fe1",
    strip_prefix = "rules_cc-0.0.17",
    urls = ["https://github.com/bazelbuild/rules_cc/releases/download/0.0.17/rules_cc-0.0.17.tar.gz"],
)

http_archive(
    name = "rules_android_ndk",
    sha256 = "89bf5012567a5bade4c78eac5ac56c336695c3bfd281a9b0894ff6605328d2d5",
    strip_prefix = "rules_android_ndk-0.1.3",
    url = "https://github.com/bazelbuild/rules_android_ndk/releases/download/v0.1.3/rules_android_ndk-v0.1.3.tar.gz",
)
load("@rules_android_ndk//:rules.bzl", "android_ndk_repository")

android_ndk_repository(name = "androidndk")

register_toolchains("@androidndk//:all")

[wxfred]

I set the api_level for android_ndk_repository, only 1 error comes

WORKSPACE
...
android_ndk_repository(
    name = "androidndk",
    api_level = 21, # add this
)
...

$env:ANDROID_NDK_HOME="C:/Users/xxx/AppData/Local/Android/Sdk/ndk/21.0.6113669"
bazel build //:jni --cpu=arm64-v8a --crosstool_top=@androidndk//:toolchain

INFO: Analyzed target //:jni (3 packages loaded, 4032 targets configured).
INFO: Found 1 target...
ERROR: C:/xxx/bazelndktest-pure/BUILD:9:11: Linking libjni.so failed: (Exit 1): clang.exe failed: error executing command (from target //:jni) external\androidndk\toolchains\llvm\prebuilt\windows-x86_64\bin\clang.exe @bazel-out/arm64-v8a-fastbuild/bin/libjni.so-2.params
ld.lld: error: unknown -z value: separate-code
clang: error: linker command failed with exit code 1 (use -v to see invocation)
Target //:jni failed to build
Use --verbose_failures to see the command lines of failed build steps.
INFO: Elapsed time: 4.365s, Critical Path: 0.48s
INFO: 4 processes: 3 internal, 1 local.
FAILED: Build did NOT complete successfully

[wxfred]

libjni.so-2.params

-no-canonical-prefixes
--target=aarch64-linux-android21
-fdiagnostics-color
-Wl,-z,noexecstack
-Wl,-zseparate-code
-Wl,--no-rosegment
-Wl,-z,max-page-size=4096
-Wl,--gc-sections
-Wl,--exclude-libs,libgcc.a
-Wl,--build-id=md5
-Wl,--undefined-glob='Java_*'
-Wl,--undefined-glob='JNI_*'
-Wl,-S
-shared
-Wl,-z,text
-Wl,--exclude-libs,libunwind.a
-fuse-ld=lld
bazel-out/arm64-v8a-fastbuild/bin/_objs/jni/jni.o
-lc
-lm
-latomic
-ldl
-o
bazel-out/arm64-v8a-fastbuild/bin/libjni.so

[wxfred]

After commenting out

flag_set(
    actions = actions.all_link,
    flags = ["-Wl,-zseparate-code", "-Wl,--no-rosegment"],
    features = ["crosstool_linker_lld"],
),

in C:\Users\xxx\bri6i4bz\external\rules_android_ndk\ndk_cc_toolchain_config.bzl, i finally got libjni.so.
Is -zseparate-code a typo or not supported in windows?

[ted-xie]

What version of rules_android_ndk, the Android NDK, and Bazel were you using?

I'm not familiar with the individual Windows C++ toolchain flags, so I can't really say if that particular flag is supported, but your initial error report indicates you were using the old NDK and toolchain-related flags (--cpu, --crosstool_top). The newer behavior should be captured by --android_platforms and --platforms.

[wxfred]

What version of rules_android_ndk, the Android NDK, and Bazel were you using?

rules_android_ndk-0.1.3
Android NDK: 21
Bazel: 6.5.0

C:\Users\xxx\AppData\Local\Android\Sdk\ndk\21.0.6113669\toolchains\llvm\prebuilt\windows-x86_64\bin\clang.exe --version
Android (5900059 based on r365631c) clang version 9.0.8 (https://android.googlesource.com/toolchain/llvm-project 207d7abc1a2abf3ef8d4301736d6a7ebc224a290) (based on LLVM 9.0.8svn)
Target: x86_64-w64-windows-gnu
Thread model: posix
InstalledDir: C:\Users\xxx\AppData\Local\Android\Sdk\ndk\21.0.6113669\toolchains\llvm\prebuilt\windows-x86_64\bin

I'm not familiar with the individual Windows C++ toolchain flags, so I can't really say if that particular flag is supported, but your initial error report indicates you were using the old NDK and toolchain-related flags (--cpu, --crosstool_top). The newer behavior should be captured by --android_platforms and --platforms.

I see that the README file is updated, and the Legacy WORKSPACE setup is complicated. I just need to compile the c++ codes without building java, I think maybe others also have the same requirement. It will be nice to add a Legacy WORKSPACE setup for only C/C++ guide with less config.

in C:\Users\xxx\bri6i4bz\external\rules_android_ndk\ndk_cc_toolchain_config.bzl, i finally got libjni.so.
Is -zseparate-code a typo or not supported in windows?

Could you take a look at your xxx.so-2.params to check whether there is a -zseparate-code flag?
The other flags in ndk_cc_toolchain_config.bzl are like -Wl,-z,xxxxxx, only this is -Wl,-zseparate-code without , as a separate. And I can‘t find any -zseparate-code or separate-code infos in google.

ld.lld: error: unknown -z value: separate-code

Is this a wrong link flag? or my ndk version is too low?

[ted-xie]

Thanks for the info! I would highly recommend you to try upgrading to at least Bazel 7.5; Bazel 6 support for this codebase is not well tested.

Yes, the legacy WORKSPACE setup is complicated -- it became much more complicated due to interoperating dependencies in newer ruleset versions due to Bazel 8 compatibility requirements.

It will be nice to add a Legacy WORKSPACE setup for only C/C++ guide with less config.

I took a brief look at this today. We already have an only C++ example app ("cpu_features"), and its WORKSPACE was needlessly complicated. I tried updating it in #106 but there are some complications with Bazel 6 and 7 compatibility at the moment unfortunately.

I haven't taken a look at the Windows portion of your questions yet; I want to at least make the minimal C++ app work on Linux first before we dive into Windows toolchain issues.