Skip to content

This sampling decision logic is duplicated in the async version (_async_with_span_handle) at lines 893-922. Consider extracting this into a shared helper function to avoid code duplication and ensure consistent behavior between sync and async implementations. The logic spans approximately 30 lines and is identical in both places, making it a prime candidate for refactoring. #82

@CorentinGS

Description

@CorentinGS

This sampling decision logic is duplicated in the async version (_async_with_span_handle) at lines 893-922. Consider extracting this into a shared helper function to avoid code duplication and ensure consistent behavior between sync and async implementations. The logic spans approximately 30 lines and is identical in both places, making it a prime candidate for refactoring.

Originally posted by @Copilot in #32 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions