Skip to content

The type checks in these two lines of Python can probably be removed. #56

@lyciumlee

Description

@lyciumlee

if(not isinstance(weights[key],Decimal)):

https://github.com/balancer/balpy/blob/77d787a06b147aab40c0d08d22af11846b5e989b/balpy/balancerv2cad/src/balancerv2cad/WeightedPool.py#L46C16-L46C16

If the user of the library wants to ensure that the input integers do not lose precision, they must pass in a string of a floating-point number to trigger the logic of factory_fees.update. This approach is quite unintuitive, as externally one could directly pass in a Decimal data

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions