From 4176f537a7cbfefe1540d6e2d832fdb535939cc7 Mon Sep 17 00:00:00 2001
From: DjDeveloperr <hey@djdev.me>
Date: Thu, 29 Oct 2026 00:34:17 -0400
Subject: [PATCH] drm/asahi: g17: say what the stampless render retirement
 relies on

A render group whose completion stamps stall retires on its pass record
after STAMP_FALLBACK_NS. The comment said the stamps follow the cache
maintenance after a pass, but not that this path has no such evidence:
whether the firmware completes the maintenance before it advances the
done cursors is not known. Say that a group retired this way relies on
the 50 ms bound for its counts, stores and exported timestamps to be
visible. Comment only.

Signed-off-by: DjDeveloperr <hey@djdev.me>
---
 drivers/gpu/drm/asahi/g17/queue/render/retirement.rs | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/asahi/g17/queue/render/retirement.rs b/drivers/gpu/drm/asahi/g17/queue/render/retirement.rs
index 9332d11a7f4b2..a62d291ea3d92 100644
--- a/drivers/gpu/drm/asahi/g17/queue/render/retirement.rs
+++ b/drivers/gpu/drm/asahi/g17/queue/render/retirement.rs
@@ -163,6 +163,11 @@ pub(crate) fn observe(ticket: &Ticket, snapshot: Snapshot) -> Result<Observation
 /// stop one kick short while the pass record shows the group (and later groups) executed, and
 /// no later event moves them. Without a bound the client waits for the scheduler watchdog and
 /// its renewals, then loses its device. Compute applies the same bound to its records.
+///
+/// Nothing here proves that the maintenance finished: whether the firmware completes it before
+/// it advances the done cursors is not known. A group retired this way relies on this bound for
+/// its counts and stores to be visible, both for the fence and for the timestamps the host then
+/// writes (`completion::Output::publish()`).
 pub(crate) const STAMP_FALLBACK_NS: u64 = 50_000_000;
 const _: () = assert!(STAMP_FALLBACK_NS * 4 <= crate::g17::job::TIMEOUT_MS as u64 * 1_000_000);
 
@@ -184,7 +189,8 @@ pub(crate) fn note_stampless(slot: u16, ordinal: u64) {
 }
 
 /// Retire an executed, consumed front group without its stamps, once [`STAMP_FALLBACK_NS`]
-/// has passed. The caller decides that bound; this re-checks execution and consumption.
+/// has passed. The caller decides that bound; this re-checks execution and consumption. Unlike
+/// the stamped path, it has no post-maintenance evidence; see [`STAMP_FALLBACK_NS`].
 pub(crate) fn poll_stampless(ticket: &mut Ticket, memory: &mut impl Memory) -> Result<Poll> {
     fence(Ordering::Acquire);
     let snapshot = memory.snapshot(ticket.ordinal)?;