Skip to content
This repository was archived by the owner on Dec 16, 2023. It is now read-only.
This repository was archived by the owner on Dec 16, 2023. It is now read-only.

regex in catalog.js chokes on CRLF replay files when .slice() invoked #153

@ggb667

Description

@ggb667

I know its GIT screwing these up, but headers are defined as CRLF in the standard, so the file ought to be able to handle either format. But it does not. This leads to people checking things out and tests failing that ran locally and run on the remote jenkins, but fail locally.

Sometimes you get a warning that the method .slice() was invoked on null, if you are in a debugger, but when running mocha from the command like you get an unhelpful message:

(node:11932) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): Error: POST http://uso12degx03:3051/ refused: not recording and no network access

It was choking on the first value "accept: text/xml" when it tried to match ^(.?):\s+(.)$

Line 59 (and others if you fix this one).
var _line$match$slice = line.match(/^(.?):\s+(.)$/).slice(1),

line.match(/^(.?):\s+(.)$/) is null so the method invocation explodes.

Work around:

  1. Add to a .gitattributes file
    /**/replay* text eol=lf

  2. Change the files to LF

  3. Run
    git config --global core.autocrlf input

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions