From 9a5f48289ed27756a3209a4fb236cd483947afa4 Mon Sep 17 00:00:00 2001 From: Ibrahim Salem Date: Tue, 26 Apr 2022 12:19:46 +0200 Subject: [PATCH 1/3] fixing issue: uninitialized constant ActiveadminSettingsCached::DSL (NameError) --- lib/activeadmin_settings_cached.rb | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/activeadmin_settings_cached.rb b/lib/activeadmin_settings_cached.rb index d3e5bb5..9d41552 100644 --- a/lib/activeadmin_settings_cached.rb +++ b/lib/activeadmin_settings_cached.rb @@ -1,6 +1,7 @@ # frozen_string_literal: true require 'activeadmin_settings_cached/engine' +require 'activeadmin_settings_cached/dsl' module ActiveadminSettingsCached class Configuration From 0cca9bc875348f65424b19459a2d41b88a408045 Mon Sep 17 00:00:00 2001 From: Ibrahim Salem Date: Tue, 26 Apr 2022 12:51:38 +0200 Subject: [PATCH 2/3] enabling boolean, time picker input fields --- lib/activeadmin_settings_cached/model.rb | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/lib/activeadmin_settings_cached/model.rb b/lib/activeadmin_settings_cached/model.rb index 5073758..8e19c01 100644 --- a/lib/activeadmin_settings_cached/model.rb +++ b/lib/activeadmin_settings_cached/model.rb @@ -26,11 +26,23 @@ def field_options(settings_name, key_name) collection: default_value, selected: value, } - elsif (default_value.is_a?(TrueClass) || default_value.is_a?(FalseClass)) && - display[settings_name].to_s == 'boolean' + elsif (field_name.include?("time") || field_name.include?("hour")) + { + as: :time_picker, + input_html: { value: value, placeholder: default_value }, + } + elsif (default_value.is_a?(TrueClass) || default_value.is_a?(FalseClass)) { + as: :boolean, input_html: { checked: value }, label: '', checked_value: 'true', unchecked_value: 'false' } + + + #elsif (default_value.is_a?(TrueClass) || default_value.is_a?(FalseClass)) && + # display[settings_name].to_s == 'boolean' + # { + # input_html: { checked: value }, label: '', checked_value: 'true', unchecked_value: 'false' + # } else { input_html: { value: value, placeholder: default_value }, From 3d6a3a7f5e3c16fb7584a75398463f18cfc948c3 Mon Sep 17 00:00:00 2001 From: Ibrahim Salem Date: Tue, 26 Apr 2022 20:30:44 +0200 Subject: [PATCH 3/3] sort fields --- app/views/admin/settings/_index.html.erb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/views/admin/settings/_index.html.erb b/app/views/admin/settings/_index.html.erb index adf2e4f..2993d30 100644 --- a/app/views/admin/settings/_index.html.erb +++ b/app/views/admin/settings/_index.html.erb @@ -8,7 +8,7 @@ - <% settings_model.settings.each_pair do |field_name, value| %> + <% settings_model.settings.sort.to_h.each_pair do |field_name, value| %> <%= f.label field_name, t("settings.attributes.#{field_name}", default: field_name) %>