diff --git a/packages/engine/src/prompts.ts b/packages/engine/src/prompts.ts index 223fc0a..9e65108 100644 --- a/packages/engine/src/prompts.ts +++ b/packages/engine/src/prompts.ts @@ -424,7 +424,7 @@ Review this like the code change it is, using run_command: 1. Install exactly what is locked with the project's own tool and lockfile (for example composer install, npm ci, bun install --frozen-lockfile, yarn install --immutable, pnpm install --frozen-lockfile, go mod download, poetry install, uv sync, bundle install, cargo fetch). An install that fails, or a lockfile out of sync with its manifest (composer validate, npm ci), is a finding. 2. Build or type check the project and run the tests that exercise code using the changed packages. When one fails, check that the changed packages cause it rather than the sandbox (a missing service or credential), then report it with the command you ran. 3. For each version change, above all major ones, find what changed upstream between the two versions: the package's changelog or release notes (from its registry or repository over the network, or from the installed package's CHANGELOG), or by comparing the installed APIs with what the code calls. Then grep the repository for the code that uses the package. Report a breaking change only when this repository uses the API it breaks, and name the call site. -4. Report a known vulnerability in a locked version when an audit tool shows it (composer audit, npm audit, pip-audit, govulncheck). +4. Report a known vulnerability when an audit tool shows it (composer audit, npm audit, pip-audit, govulncheck) and this pull request adds it: the new version is affected by an advisory that the version it replaces was not. An advisory that also affects the replaced version, or a package this pull request does not change, was there before and is not a finding, even when a newer release fixes it; a pull request that leaves the project no worse is not blocked for what it did not fix. Put findings on the lockfile line that sets the new version (the "version" line or entry for that package). When the line is not in the diff, put it on the closest changed line of that package's entry and name the package in the title. A bump that installs, builds, and passes its tests with no breaking change this code depends on needs no finding. `; }