From 104c5b8b4a1299d5c4d0a0c147aa0353e02559f4 Mon Sep 17 00:00:00 2001 From: Matthew Ball Date: Fri, 20 Nov 2026 11:39:03 -0800 Subject: [PATCH] fix(access-control): stop logging bearer tokens and request headers checkComputingUnitAccess logged the extracted bearer token in full at INFO, and alongside it the whole request URI and header map, which also carry the Authorization token and the access-token query parameter. Both lines wrote live credentials into the logs on every authorize call. The token log is removed and the request log now records only the request path, which carries no secret. --- .../texera/service/resource/AccessControlResource.scala | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/access-control-service/src/main/scala/org/apache/texera/service/resource/AccessControlResource.scala b/access-control-service/src/main/scala/org/apache/texera/service/resource/AccessControlResource.scala index 2d209be59f8..e28726dc03a 100644 --- a/access-control-service/src/main/scala/org/apache/texera/service/resource/AccessControlResource.scala +++ b/access-control-service/src/main/scala/org/apache/texera/service/resource/AccessControlResource.scala @@ -137,9 +137,8 @@ object AccessControlResource extends LazyLogging { .mapValues(values => values.asScala.headOption.getOrElse("")) .toMap - logger.info( - s"Request URI: ${uriInfo.getRequestUri} and headers: ${headers.getRequestHeaders.asScala} and queryParams: $queryParams" - ) + // Log only the request path; the URI query, headers, and body all carry the bearer token. + logger.info(s"Authorizing computing-unit access for path ${uriInfo.getPath}") val token: String = { val qToken = queryParams.get("access-token").filter(_.nonEmpty) @@ -151,7 +150,6 @@ object AccessControlResource extends LazyLogging { val bToken = bodyOpt.flatMap(extractTokenFromBody) qToken.orElse(hToken).orElse(bToken).getOrElse("") } - logger.info(s"token extracted from request $token") val cuid = queryParams.get("cuid").filter(_.nonEmpty).getOrElse { uriInfo.getPath match {