From db1e202cd11f917c7bb09caaf77af1e79f12183a Mon Sep 17 00:00:00 2001 From: shrirangmhalgi Date: Thu, 21 May 2026 17:53:08 -0700 Subject: [PATCH] [SPARK-54770][PYTHON] Replace dead assert with proper error in _create_converter The else branch in _create_converter was unreachable (marked pragma: no cover) because _need_converter guards entry and every type it returns True for has a corresponding handler. Replace with a raise at function level that works even with Python -O flag. --- python/pyspark/sql/conversion.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/python/pyspark/sql/conversion.py b/python/pyspark/sql/conversion.py index 9110a63827253..745680ad0b713 100644 --- a/python/pyspark/sql/conversion.py +++ b/python/pyspark/sql/conversion.py @@ -891,8 +891,8 @@ def convert_other(value: Any) -> Any: return value return convert_other - else: # pragma: no cover - assert False, f"Need converter for {dataType} but failed to find one." + + assert False, f"_need_converter returned True for {dataType} but no converter was created." @staticmethod def convert(data: Sequence[Any], schema: StructType, use_large_var_types: bool) -> "pa.Table":