From 9ab57978dccabd866987175e33342477f19c0392 Mon Sep 17 00:00:00 2001 From: Aaron Niskode-Dossett Date: Mon, 2 Nov 2026 08:42:19 -0600 Subject: [PATCH] Use Stream.toList() for internal read-only lists --- .../org/apache/parquet/avro/ReflectClassValidator.java | 3 +-- .../filter2/recordlevel/FilteringRecordMaterializer.java | 3 +-- .../java/org/apache/parquet/hadoop/ParquetFileReader.java | 3 +-- .../apache/parquet/hadoop/rewrite/ParquetRewriter.java | 8 ++++---- 4 files changed, 7 insertions(+), 10 deletions(-) diff --git a/parquet-avro/src/main/java/org/apache/parquet/avro/ReflectClassValidator.java b/parquet-avro/src/main/java/org/apache/parquet/avro/ReflectClassValidator.java index bcc6807ac4..a17f30130b 100644 --- a/parquet-avro/src/main/java/org/apache/parquet/avro/ReflectClassValidator.java +++ b/parquet-avro/src/main/java/org/apache/parquet/avro/ReflectClassValidator.java @@ -22,7 +22,6 @@ import java.util.HashSet; import java.util.List; import java.util.Set; -import java.util.stream.Collectors; import java.util.stream.Stream; abstract class ReflectClassValidator { @@ -33,7 +32,7 @@ static class PackageValidator extends ReflectClassValidator { private final List trustedPackagePrefixes = Stream.of(AvroConverters.SERIALIZABLE_PACKAGES) .map(p -> p.endsWith(".") ? p : p + ".") - .collect(Collectors.toList()); + .toList(); private final boolean trustAllPackages = trustedPackagePrefixes.size() == 1 && "*".equals(trustedPackagePrefixes.get(0)); // The primitive "class names" based on Class.isPrimitive() diff --git a/parquet-column/src/main/java/org/apache/parquet/filter2/recordlevel/FilteringRecordMaterializer.java b/parquet-column/src/main/java/org/apache/parquet/filter2/recordlevel/FilteringRecordMaterializer.java index 687a4e18a2..04d24a4704 100644 --- a/parquet-column/src/main/java/org/apache/parquet/filter2/recordlevel/FilteringRecordMaterializer.java +++ b/parquet-column/src/main/java/org/apache/parquet/filter2/recordlevel/FilteringRecordMaterializer.java @@ -25,7 +25,6 @@ import java.util.List; import java.util.Map; import java.util.Objects; -import java.util.stream.Collectors; import org.apache.parquet.filter2.recordlevel.IncrementallyUpdatedFilterPredicate.ValueInspector; import org.apache.parquet.hadoop.metadata.ColumnPath; import org.apache.parquet.io.PrimitiveColumnIO; @@ -65,7 +64,7 @@ public FilteringRecordMaterializer( for (PrimitiveColumnIO c : columnIOs) { List indexFieldPath = - Arrays.stream(c.getIndexFieldPath()).boxed().collect(Collectors.toList()); + Arrays.stream(c.getIndexFieldPath()).boxed().toList(); columnIOsByIndexFieldPath.put(indexFieldPath, c); } diff --git a/parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileReader.java b/parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileReader.java index d29738a6d8..5a611b41d1 100644 --- a/parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileReader.java +++ b/parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileReader.java @@ -57,7 +57,6 @@ import java.util.concurrent.Future; import java.util.concurrent.TimeUnit; import java.util.concurrent.TimeoutException; -import java.util.stream.Collectors; import java.util.zip.CRC32; import org.apache.hadoop.conf.Configuration; import org.apache.hadoop.fs.FileStatus; @@ -415,7 +414,7 @@ private static List listFiles(Configuration conf, FileStatus fileSta throw new RuntimeException(e); } }) - .collect(Collectors.toList()); + .toList(); } else { return Collections.singletonList(fileStatus); } diff --git a/parquet-hadoop/src/main/java/org/apache/parquet/hadoop/rewrite/ParquetRewriter.java b/parquet-hadoop/src/main/java/org/apache/parquet/hadoop/rewrite/ParquetRewriter.java index 36b978180d..fce8866850 100644 --- a/parquet-hadoop/src/main/java/org/apache/parquet/hadoop/rewrite/ParquetRewriter.java +++ b/parquet-hadoop/src/main/java/org/apache/parquet/hadoop/rewrite/ParquetRewriter.java @@ -171,7 +171,7 @@ public ParquetRewriter(RewriteOptions options) throws IOException { "Start rewriting {} input file(s) {} to {}", inputFiles.size() + inputFilesToJoin.size(), Stream.concat(options.getParquetInputFiles().stream(), options.getParquetInputFilesToJoin().stream()) - .collect(Collectors.toList()), + .toList(), out); if (options.getMaskColumns() != null) { @@ -298,7 +298,7 @@ private Map getExtraMetadata(RewriteOptions options) { allFiles = new ArrayList<>(inputFiles); } else { allFiles = Stream.concat(inputFiles.stream(), inputFilesToJoin.stream()) - .collect(Collectors.toList()); + .toList(); } Map result = new HashMap<>(); result.put( @@ -317,10 +317,10 @@ private void ensureRowCount() { if (!inputFilesToJoin.isEmpty()) { List blocksRowCountsL = inputFiles.stream() .flatMap(x -> x.getFooter().getBlocks().stream().map(BlockMetaData::getRowCount)) - .collect(Collectors.toList()); + .toList(); List blocksRowCountsR = inputFilesToJoin.stream() .flatMap(x -> x.getFooter().getBlocks().stream().map(BlockMetaData::getRowCount)) - .collect(Collectors.toList()); + .toList(); if (!blocksRowCountsL.equals(blocksRowCountsR)) { throw new IllegalArgumentException( "The number of rows in each block must match! Left blocks row counts: " + blocksRowCountsL