Verify stage caches an empty directory for the main JAR

[mensinda]

Affected version

1.2.2

Bug description

When running mvn clean compile and mvn clean verify in that order, the cached main artifact (the JAR in the build-cache/v1.1) is a directory instead of a ZIP/JAR file.

drwxrwxr-x 2 d_mensinger d_mensinger  4096 Feb  4 09:51 maven-build-cache-test.jar
-rw-rw-r-- 1 d_mensinger d_mensinger 34935 Feb  4 09:51 buildinfo.xml
-rw------- 1 d_mensinger d_mensinger   382 Feb  4 09:51 maven-build-cache-test-mvn-cache-ext-extra-output-1.zip
-rw------- 1 d_mensinger d_mensinger   491 Feb  4 09:51 maven-build-cache-test-mvn-cache-ext-extra-output-2.zip
-rw------- 1 d_mensinger d_mensinger   207 Feb  4 09:51 maven-build-cache-test-mvn-cache-ext-extra-output-3.zip
-rw-rw-r-- 1 d_mensinger d_mensinger  2590 Feb  4 09:51 maven-build-cache-test-sources.jar


Checking JARs in cache dir:
.m2-home/build-cache/v1.1/test/maven-build-cache-test/1cee1f6bd6426d28c48863f31706b2012a89eb9322ef894692b3ae71d8c4b622/local/maven-build-cache-test.jar: directory
.m2-home/build-cache/v1.1/test/maven-build-cache-test/1cee1f6bd6426d28c48863f31706b2012a89eb9322ef894692b3ae71d8c4b622/local/maven-build-cache-test-sources.jar: Zip archive data, at least v1.0 to extract, compression method=store


Checking JARs in target dir:
target/maven-build-cache-test-1.0-SNAPSHOT.jar: Zip archive data, at least v1.0 to extract, compression method=store
target/maven-build-cache-test-1.0-SNAPSHOT-sources.jar: Zip archive data, at least v1.0 to extract, compression method=store

This is likely related to #394.

---

To reproduce

For convenience I have created a reproducer Project here: https://github.com/mensinda/maven-build-cache-test/tree/verify-fail

Please only use the verify-fail branch!

Then just run the run.sh shell script. This will automatically execute the relevant maven commands. It will also ensure that a local m2 Repository + build cache is used for better reproducibility.

[mensinda]

I also had a look at the buildinfo.xml at the relevant stages and the cache state:

Running only mvn clean compile

The artifact section in the buildinfo.xml:

  <artifact>
    <groupId>test</groupId>
    <artifactId>maven-build-cache-test</artifactId>
    <version>1.0-SNAPSHOT</version>
    <type>jar</type>
    <fileName>maven-build-cache-test.jar</fileName>
    <filePath>target/classes</filePath>
    <isDirectory>true</isDirectory>
  </artifact>

The maven-build-cache-test.jar is a ZIP file

Running only mvn clean verify

The artifact section in the buildinfo.xml:

  <artifact>
    <groupId>test</groupId>
    <artifactId>maven-build-cache-test</artifactId>
    <version>1.0-SNAPSHOT</version>
    <type>jar</type>
    <fileName>maven-build-cache-test.jar</fileName>
    <fileHash>636d1f4d28f4ca6b6a87209000d07ea6d967b90d14191e80cb519742379c7ecd</fileHash>
    <fileSize>2757</fileSize>
    <filePath>target/maven-build-cache-test-1.0-SNAPSHOT.jar</filePath>
  </artifact>

The maven-build-cache-test.jar is a ZIP file

Running mvn clean compile and then mvn clean verify

The artifact section in the buildinfo.xml:

  <artifact>
    <groupId>test</groupId>
    <artifactId>maven-build-cache-test</artifactId>
    <version>1.0-SNAPSHOT</version>
    <type>jar</type>
    <fileName>maven-build-cache-test.jar</fileName>
    <filePath>target/classes</filePath>
    <isDirectory>true</isDirectory>
  </artifact>

The maven-build-cache-test.jar is an empty directory

---

@cowwoc There seems to be a logic error related to #394 when the compile results are restored and then the built / packaged JAR is (at least supposed to be) cached.

This only seems to affect the main JAR, the artefact from the maven-source-plugin is stored / cached correctly.

[mensinda]

Additionally, when swapping clean verify with clean install in the script, maven fails with:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-install-plugin:3.1.2:install (default-install) on project maven-build-cache-test: The packaging plugin for project maven-build-cache-test did not assign a main file to the project but it has attachments. Change packaging to 'pom'. -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-install-plugin:3.1.2:install (default-install) on project maven-build-cache-test: The packaging plugin for project maven-build-cache-test did not assign a main file to the project but it has attachments. Change packaging to 'pom'.
    at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2 (MojoExecutor.java:333)
    at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute (MojoExecutor.java:316)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:212)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:174)
    at org.apache.maven.lifecycle.internal.MojoExecutor.access$000 (MojoExecutor.java:75)
    at org.apache.maven.lifecycle.internal.MojoExecutor$1.run (MojoExecutor.java:162)
    at org.apache.maven.buildcache.BuildCacheMojosExecutionStrategy.restoreProject (BuildCacheMojosExecutionStrategy.java:341)
    at org.apache.maven.buildcache.BuildCacheMojosExecutionStrategy.execute (BuildCacheMojosExecutionStrategy.java:149)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:159)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:105)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:73)
    at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:53)
    at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:118)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:261)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:173)
    at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:101)
    at org.apache.maven.cli.MavenCli.execute (MavenCli.java:906)
    at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:283)
    at org.apache.maven.cli.MavenCli.main (MavenCli.java:206)
    at jdk.internal.reflect.DirectMethodHandleAccessor.invoke (DirectMethodHandleAccessor.java:104)
    at java.lang.reflect.Method.invoke (Method.java:565)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:255)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:201)
    at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:361)
    at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:314)
Caused by: org.apache.maven.plugin.MojoExecutionException: The packaging plugin for project maven-build-cache-test did not assign a main file to the project but it has attachments. Change packaging to 'pom'.
    at org.apache.maven.plugins.install.InstallMojo.processProject (InstallMojo.java:228)
    at org.apache.maven.plugins.install.InstallMojo.execute (InstallMojo.java:131)
    at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:126)
    at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2 (MojoExecutor.java:328)
    at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute (MojoExecutor.java:316)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:212)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:174)
    at org.apache.maven.lifecycle.internal.MojoExecutor.access$000 (MojoExecutor.java:75)
    at org.apache.maven.lifecycle.internal.MojoExecutor$1.run (MojoExecutor.java:162)
    at org.apache.maven.buildcache.BuildCacheMojosExecutionStrategy.restoreProject (BuildCacheMojosExecutionStrategy.java:341)
    at org.apache.maven.buildcache.BuildCacheMojosExecutionStrategy.execute (BuildCacheMojosExecutionStrategy.java:149)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:159)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:105)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:73)
    at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:53)
    at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:118)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:261)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:173)
    at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:101)
    at org.apache.maven.cli.MavenCli.execute (MavenCli.java:906)
    at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:283)
    at org.apache.maven.cli.MavenCli.main (MavenCli.java:206)
    at jdk.internal.reflect.DirectMethodHandleAccessor.invoke (DirectMethodHandleAccessor.java:104)
    at java.lang.reflect.Method.invoke (Method.java:565)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:255)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:201)
    at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:361)
    at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:314)

---

This issue should be fixed with #453