Skip to content

build(runtime-host): remove stale surface inputs restored after #3277 #3331

Description

@M4n5ter
English

Summary

The current main branch does not build from a clean source archive because three Runtime Host test calls pass the retired surface input.

The failure was exposed by the manual ASF source-candidate validation:

Root cause

#3277 removed surface from the Runtime Host connection inputs. #3221 was developed and validated against an older base, then added three new owned-candidate.test.ts calls that still supplied surface. The changes merged without a textual conflict, but their combined result is type-invalid.

The push CI for the #3221 merge commit was cancelled by the next push before it could validate the merged tree: https://github.com/apache/maka/actions/runs/32373288358

Expected fix

Remove the three obsolete surface inputs from packages/runtime-host/src/__tests__/owned-candidate.test.ts, then verify the merged main tree builds and type-checks. The ASF source-candidate workflow should remain unchanged; it correctly caught a clean-archive build failure.

Related work

AI use

OpenAI Codex assisted with CI-log triage and root-cause analysis. M4n5ter is the reporter of record.

中文

摘要

当前 main 无法从干净的源码归档完成构建,因为 Runtime Host 的 3 处测试调用仍传入已经移除的 surface 参数。

该问题由手动 ASF 源码候选验证暴露:

根因

#3277 已从 Runtime Host 连接输入中移除 surface#3221 基于更早的基线开发和验证,随后新增的 3 处 owned-candidate.test.ts 调用仍携带 surface。两者合并时没有文本冲突,但组合后的代码无法通过类型检查。

#3221 合并提交触发的 push CI 在验证合并树之前被下一次 push 取消:https://github.com/apache/maka/actions/runs/32373288358

预期修复

删除 packages/runtime-host/src/__tests__/owned-candidate.test.ts 中 3 个过时的 surface 输入,并验证合并后的 main 可以构建及通过类型检查。ASF 源码候选 workflow 无需修改;它正确发现了干净源码归档的构建失败。

相关工作

AI 使用说明以英文区为准。

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions