Skip to content

Commit f709ef5

Browse files
authored
Avoid eager aggregation type coverage checks on first query (#18915)
* Avoid eager aggregation type coverage checks on first query * Remove aggregation initialization comment
1 parent 2abe6e9 commit f709ef5

2 files changed

Lines changed: 10 additions & 9 deletions

File tree

‎iotdb-core/datanode/src/main/java/org/apache/iotdb/db/utils/TypeServices.java‎

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1458,15 +1458,6 @@ public void writeResult(final ColumnBuilder builder, final TsPrimitiveType resul
14581458
};
14591459
};
14601460

1461-
static {
1462-
EXTREME_VALUE_ACCUMULATOR_STRATEGY_SERVICE.check();
1463-
TIME_VALUE_ACCUMULATOR_STRATEGY_SERVICE.check();
1464-
MAX_MIN_BY_ACCUMULATOR_STRATEGY_SERVICE.check();
1465-
EVENT_WINDOW_MANAGER_PROVIDER_SERVICE.check();
1466-
OUTPUT_COLUMN_SIZE_PER_LINE_SERVICE.check();
1467-
MODE_ACCUMULATOR_PROVIDER_SERVICE.check();
1468-
}
1469-
14701461
private Aggregation() {
14711462
// Utility class
14721463
}

‎iotdb-core/datanode/src/test/java/org/apache/iotdb/db/utils/TypeServicesTest.java‎

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,16 @@
5353

5454
public class TypeServicesTest {
5555

56+
@Test
57+
public void testAggregationServicesCoverAllTypes() {
58+
TypeServices.Aggregation.EXTREME_VALUE_ACCUMULATOR_STRATEGY_SERVICE.check();
59+
TypeServices.Aggregation.TIME_VALUE_ACCUMULATOR_STRATEGY_SERVICE.check();
60+
TypeServices.Aggregation.MAX_MIN_BY_ACCUMULATOR_STRATEGY_SERVICE.check();
61+
TypeServices.Aggregation.EVENT_WINDOW_MANAGER_PROVIDER_SERVICE.check();
62+
TypeServices.Aggregation.OUTPUT_COLUMN_SIZE_PER_LINE_SERVICE.check();
63+
TypeServices.Aggregation.MODE_ACCUMULATOR_PROVIDER_SERVICE.check();
64+
}
65+
5666
@Test
5767
public void testTabletBinarySerializationMatchesLegacyFormat() throws IOException {
5868
Binary[] values = {

0 commit comments

Comments
 (0)