|
121 | 121 | Capability.V1_CREATE_VIEW, |
122 | 122 | Capability.V1_REGISTER_VIEW, |
123 | 123 | Capability.V1_DELETE_VIEW, |
| 124 | + Capability.V1_RENAME_VIEW, |
124 | 125 | Capability.V1_SUBMIT_TABLE_SCAN_PLAN, |
125 | 126 | Capability.V1_TABLE_SCAN_PLAN_TASKS, |
126 | 127 | ] |
@@ -2950,6 +2951,125 @@ def test_drop_view_204(rest_mock: Mocker) -> None: |
2950 | 2951 | RestCatalog("rest", uri=TEST_URI, token=TEST_TOKEN).drop_view(("some_namespace", "some_view")) |
2951 | 2952 |
|
2952 | 2953 |
|
| 2954 | +def test_rename_view_204(rest_mock: Mocker) -> None: |
| 2955 | + from_identifier = ("some_namespace", "old_view") |
| 2956 | + to_identifier = ("some_namespace", "new_view") |
| 2957 | + rest_mock.head( |
| 2958 | + f"{TEST_URI}v1/namespaces/some_namespace", |
| 2959 | + status_code=200, |
| 2960 | + request_headers=TEST_HEADERS, |
| 2961 | + ) |
| 2962 | + rest_mock.post( |
| 2963 | + f"{TEST_URI}v1/views/rename", |
| 2964 | + json={ |
| 2965 | + "source": {"namespace": ["some_namespace"], "name": "old_view"}, |
| 2966 | + "destination": {"namespace": ["some_namespace"], "name": "new_view"}, |
| 2967 | + }, |
| 2968 | + status_code=204, |
| 2969 | + request_headers=TEST_HEADERS, |
| 2970 | + ) |
| 2971 | + catalog = RestCatalog("rest", uri=TEST_URI, token=TEST_TOKEN) |
| 2972 | + catalog.rename_view(from_identifier, to_identifier) |
| 2973 | + assert ( |
| 2974 | + rest_mock.last_request.text == """{"source": {"namespace": ["some_namespace"], "name": "old_view"}, """ |
| 2975 | + """"destination": {"namespace": ["some_namespace"], "name": "new_view"}}""" |
| 2976 | + ) |
| 2977 | + |
| 2978 | + |
| 2979 | +def test_rename_view_404(rest_mock: Mocker) -> None: |
| 2980 | + from_identifier = ("some_namespace", "non_existent_view") |
| 2981 | + to_identifier = ("some_namespace", "new_view") |
| 2982 | + rest_mock.head( |
| 2983 | + f"{TEST_URI}v1/namespaces/some_namespace", |
| 2984 | + status_code=200, |
| 2985 | + request_headers=TEST_HEADERS, |
| 2986 | + ) |
| 2987 | + rest_mock.post( |
| 2988 | + f"{TEST_URI}v1/views/rename", |
| 2989 | + json={ |
| 2990 | + "error": { |
| 2991 | + "message": "View does not exist: some_namespace.non_existent_view", |
| 2992 | + "type": "NoSuchViewException", |
| 2993 | + "code": 404, |
| 2994 | + } |
| 2995 | + }, |
| 2996 | + status_code=404, |
| 2997 | + request_headers=TEST_HEADERS, |
| 2998 | + ) |
| 2999 | + catalog = RestCatalog("rest", uri=TEST_URI, token=TEST_TOKEN) |
| 3000 | + with pytest.raises(NoSuchViewError) as exc_info: |
| 3001 | + catalog.rename_view(from_identifier, to_identifier) |
| 3002 | + assert "View does not exist: some_namespace.non_existent_view" in str(exc_info.value) |
| 3003 | + |
| 3004 | + |
| 3005 | +def test_rename_view_409(rest_mock: Mocker) -> None: |
| 3006 | + from_identifier = ("some_namespace", "old_view") |
| 3007 | + to_identifier = ("some_namespace", "existing_view") |
| 3008 | + rest_mock.head( |
| 3009 | + f"{TEST_URI}v1/namespaces/some_namespace", |
| 3010 | + status_code=200, |
| 3011 | + request_headers=TEST_HEADERS, |
| 3012 | + ) |
| 3013 | + rest_mock.post( |
| 3014 | + f"{TEST_URI}v1/views/rename", |
| 3015 | + json={ |
| 3016 | + "error": { |
| 3017 | + "message": "View already exists: some_namespace.existing_view", |
| 3018 | + "type": "ViewAlreadyExistsException", |
| 3019 | + "code": 409, |
| 3020 | + } |
| 3021 | + }, |
| 3022 | + status_code=409, |
| 3023 | + request_headers=TEST_HEADERS, |
| 3024 | + ) |
| 3025 | + catalog = RestCatalog("rest", uri=TEST_URI, token=TEST_TOKEN) |
| 3026 | + with pytest.raises(ViewAlreadyExistsError) as exc_info: |
| 3027 | + catalog.rename_view(from_identifier, to_identifier) |
| 3028 | + assert "View already exists: some_namespace.existing_view" in str(exc_info.value) |
| 3029 | + |
| 3030 | + |
| 3031 | +def test_rename_view_source_namespace_does_not_exist(rest_mock: Mocker) -> None: |
| 3032 | + from_identifier = ("non_existent_namespace", "old_view") |
| 3033 | + to_identifier = ("some_namespace", "new_view") |
| 3034 | + |
| 3035 | + rest_mock.head( |
| 3036 | + f"{TEST_URI}v1/namespaces/non_existent_namespace", |
| 3037 | + status_code=404, |
| 3038 | + request_headers=TEST_HEADERS, |
| 3039 | + ) |
| 3040 | + rest_mock.head( |
| 3041 | + f"{TEST_URI}v1/namespaces/some_namespace", |
| 3042 | + status_code=200, |
| 3043 | + request_headers=TEST_HEADERS, |
| 3044 | + ) |
| 3045 | + |
| 3046 | + catalog = RestCatalog("rest", uri=TEST_URI, token=TEST_TOKEN) |
| 3047 | + with pytest.raises(NoSuchNamespaceError) as exc_info: |
| 3048 | + catalog.rename_view(from_identifier, to_identifier) |
| 3049 | + assert "Source namespace does not exist: ('non_existent_namespace',)" in str(exc_info.value) |
| 3050 | + |
| 3051 | + |
| 3052 | +def test_rename_view_destination_namespace_does_not_exist(rest_mock: Mocker) -> None: |
| 3053 | + from_identifier = ("some_namespace", "old_view") |
| 3054 | + to_identifier = ("non_existent_namespace", "new_view") |
| 3055 | + |
| 3056 | + rest_mock.head( |
| 3057 | + f"{TEST_URI}v1/namespaces/some_namespace", |
| 3058 | + status_code=200, |
| 3059 | + request_headers=TEST_HEADERS, |
| 3060 | + ) |
| 3061 | + rest_mock.head( |
| 3062 | + f"{TEST_URI}v1/namespaces/non_existent_namespace", |
| 3063 | + status_code=404, |
| 3064 | + request_headers=TEST_HEADERS, |
| 3065 | + ) |
| 3066 | + |
| 3067 | + catalog = RestCatalog("rest", uri=TEST_URI, token=TEST_TOKEN) |
| 3068 | + with pytest.raises(NoSuchNamespaceError) as exc_info: |
| 3069 | + catalog.rename_view(from_identifier, to_identifier) |
| 3070 | + assert "Destination namespace does not exist: ('non_existent_namespace',)" in str(exc_info.value) |
| 3071 | + |
| 3072 | + |
2953 | 3073 | @mock.patch("google.auth.transport.requests.Request") |
2954 | 3074 | @mock.patch("google.auth.load_credentials_from_file") |
2955 | 3075 | def test_rest_catalog_with_google_credentials_path( |
@@ -3311,6 +3431,7 @@ def test_view_endpoints_enabled_with_config(self, requests_mock: Mocker) -> None |
3311 | 3431 | # View endpoints should be supported when enabled |
3312 | 3432 | catalog._check_endpoint(Capability.V1_LIST_VIEWS) |
3313 | 3433 | catalog._check_endpoint(Capability.V1_DELETE_VIEW) |
| 3434 | + catalog._check_endpoint(Capability.V1_RENAME_VIEW) |
3314 | 3435 |
|
3315 | 3436 |
|
3316 | 3437 | def test_table_uuid_check_on_commit(rest_mock: Mocker, example_table_metadata_v2: dict[str, Any]) -> None: |
|
0 commit comments