Skip to content

Commit df809ab

Browse files
committed
Added test for namespace exists
1 parent e81f9eb commit df809ab

1 file changed

Lines changed: 58 additions & 1 deletion

File tree

‎tests/catalog/test_rest.py‎

Lines changed: 58 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3172,6 +3172,11 @@ def test_load_table_without_storage_credentials(
31723172
def test_rename_view_204(rest_mock: Mocker) -> None:
31733173
from_identifier = ("some_namespace", "old_view")
31743174
to_identifier = ("some_namespace", "new_view")
3175+
rest_mock.head(
3176+
f"{TEST_URI}v1/namespaces/some_namespace",
3177+
status_code=200,
3178+
request_headers=TEST_HEADERS,
3179+
)
31753180
rest_mock.post(
31763181
f"{TEST_URI}v1/views/rename",
31773182
json={
@@ -3185,13 +3190,18 @@ def test_rename_view_204(rest_mock: Mocker) -> None:
31853190
catalog.rename_view(from_identifier, to_identifier)
31863191
assert (
31873192
rest_mock.last_request.text
3188-
== """{"source": {"namespace": ["some_namespace"], "name": "old_view"}, "destination": {"namespace": ["some_namespace"], "name": "new_view"}}"""
3193+
== '''{"source": {"namespace": ["some_namespace"], "name": "old_view"}, "destination": {"namespace": ["some_namespace"], "name": "new_view"}}'''
31893194
)
31903195

31913196

31923197
def test_rename_view_404(rest_mock: Mocker) -> None:
31933198
from_identifier = ("some_namespace", "non_existent_view")
31943199
to_identifier = ("some_namespace", "new_view")
3200+
rest_mock.head(
3201+
f"{TEST_URI}v1/namespaces/some_namespace",
3202+
status_code=200,
3203+
request_headers=TEST_HEADERS,
3204+
)
31953205
rest_mock.post(
31963206
f"{TEST_URI}v1/views/rename",
31973207
json={
@@ -3213,6 +3223,11 @@ def test_rename_view_404(rest_mock: Mocker) -> None:
32133223
def test_rename_view_409(rest_mock: Mocker) -> None:
32143224
from_identifier = ("some_namespace", "old_view")
32153225
to_identifier = ("some_namespace", "existing_view")
3226+
rest_mock.head(
3227+
f"{TEST_URI}v1/namespaces/some_namespace",
3228+
status_code=200,
3229+
request_headers=TEST_HEADERS,
3230+
)
32163231
rest_mock.post(
32173232
f"{TEST_URI}v1/views/rename",
32183233
json={
@@ -3229,3 +3244,45 @@ def test_rename_view_409(rest_mock: Mocker) -> None:
32293244
with pytest.raises(ViewAlreadyExistsError) as exc_info:
32303245
catalog.rename_view(from_identifier, to_identifier)
32313246
assert "View already exists: some_namespace.existing_view" in str(exc_info.value)
3247+
3248+
3249+
def test_rename_view_source_namespace_does_not_exist(rest_mock: Mocker) -> None:
3250+
from_identifier = ("non_existent_namespace", "old_view")
3251+
to_identifier = ("some_namespace", "new_view")
3252+
3253+
rest_mock.head(
3254+
f"{TEST_URI}v1/namespaces/non_existent_namespace",
3255+
status_code=404,
3256+
request_headers=TEST_HEADERS,
3257+
)
3258+
rest_mock.head(
3259+
f"{TEST_URI}v1/namespaces/some_namespace",
3260+
status_code=200,
3261+
request_headers=TEST_HEADERS,
3262+
)
3263+
3264+
catalog = RestCatalog("rest", uri=TEST_URI, token=TEST_TOKEN)
3265+
with pytest.raises(NoSuchNamespaceError) as exc_info:
3266+
catalog.rename_view(from_identifier, to_identifier)
3267+
assert "Source namespace does not exist: ('non_existent_namespace',)" in str(exc_info.value)
3268+
3269+
3270+
def test_rename_view_destination_namespace_does_not_exist(rest_mock: Mocker) -> None:
3271+
from_identifier = ("some_namespace", "old_view")
3272+
to_identifier = ("non_existent_namespace", "new_view")
3273+
3274+
rest_mock.head(
3275+
f"{TEST_URI}v1/namespaces/some_namespace",
3276+
status_code=200,
3277+
request_headers=TEST_HEADERS,
3278+
)
3279+
rest_mock.head(
3280+
f"{TEST_URI}v1/namespaces/non_existent_namespace",
3281+
status_code=404,
3282+
request_headers=TEST_HEADERS,
3283+
)
3284+
3285+
catalog = RestCatalog("rest", uri=TEST_URI, token=TEST_TOKEN)
3286+
with pytest.raises(NoSuchNamespaceError) as exc_info:
3287+
catalog.rename_view(from_identifier, to_identifier)
3288+
assert "Destination namespace does not exist: non_existent_namespace" in str(exc_info.value)

0 commit comments

Comments
 (0)