Repository navigation
Commit c8502b3
REST: Don't URL-encode view names in create_view and register_view bodies (#4151)
* REST: Send raw view name in create_view and register_view bodies
create_view and register_view took the view name from
_split_identifier_for_path, which URL-quotes it for use as a path
segment, and put it in the JSON request body. A view named "my view"
was created as "my%20view". Use the raw name, as create_table and
register_table already do.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* Test REST identifiers that need URL encoding against the REST fixture
Round-trip namespace, table, and view names containing spaces, reserved
URL characters, and non-ASCII text through path, query, and body
parameters. This catches encoding mistakes like the double-encoded
list_namespaces parent and the encoded view name in create_view.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* Cover commit_table in REST identifier integration test
commit_table is the only caller of the TableIdentifier branch of
_split_identifier_for_path, so table updates had no coverage for names
that need URL encoding.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* Clarify why % is omitted from REST identifier integration test
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* Keep _split_identifier_for_path for the register_view path
Matches create_view and register_table: path from _split_identifier_for_path, raw name for the body.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* Cover register_view in REST identifier integration test
Register the created view under a second name that needs URL encoding,
now that View exposes its metadata location (#4088).
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
---------
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>1 parent a1a43c5 commit c8502b3
3 files changed
Lines changed: 92 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1312 | 1312 | | |
1313 | 1313 | | |
1314 | 1314 | | |
1315 | | - | |
| 1315 | + | |
1316 | 1316 | | |
1317 | 1317 | | |
1318 | 1318 | | |
| |||
1826 | 1826 | | |
1827 | 1827 | | |
1828 | 1828 | | |
1829 | | - | |
1830 | | - | |
| 1829 | + | |
1831 | 1830 | | |
1832 | | - | |
| 1831 | + | |
1833 | 1832 | | |
1834 | | - | |
| 1833 | + | |
1835 | 1834 | | |
1836 | 1835 | | |
1837 | | - | |
| 1836 | + | |
1838 | 1837 | | |
1839 | 1838 | | |
1840 | 1839 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
26 | | - | |
| 26 | + | |
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
| |||
1806 | 1806 | | |
1807 | 1807 | | |
1808 | 1808 | | |
| 1809 | + | |
| 1810 | + | |
| 1811 | + | |
| 1812 | + | |
| 1813 | + | |
| 1814 | + | |
| 1815 | + | |
| 1816 | + | |
| 1817 | + | |
| 1818 | + | |
| 1819 | + | |
| 1820 | + | |
| 1821 | + | |
| 1822 | + | |
| 1823 | + | |
| 1824 | + | |
| 1825 | + | |
| 1826 | + | |
| 1827 | + | |
| 1828 | + | |
| 1829 | + | |
1809 | 1830 | | |
1810 | 1831 | | |
1811 | 1832 | | |
| |||
2831 | 2852 | | |
2832 | 2853 | | |
2833 | 2854 | | |
| 2855 | + | |
| 2856 | + | |
| 2857 | + | |
| 2858 | + | |
| 2859 | + | |
| 2860 | + | |
| 2861 | + | |
| 2862 | + | |
| 2863 | + | |
| 2864 | + | |
| 2865 | + | |
| 2866 | + | |
| 2867 | + | |
| 2868 | + | |
| 2869 | + | |
| 2870 | + | |
| 2871 | + | |
| 2872 | + | |
2834 | 2873 | | |
2835 | 2874 | | |
2836 | 2875 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
719 | 719 | | |
720 | 720 | | |
721 | 721 | | |
| 722 | + | |
| 723 | + | |
| 724 | + | |
| 725 | + | |
| 726 | + | |
| 727 | + | |
| 728 | + | |
| 729 | + | |
| 730 | + | |
| 731 | + | |
| 732 | + | |
| 733 | + | |
| 734 | + | |
| 735 | + | |
| 736 | + | |
| 737 | + | |
| 738 | + | |
| 739 | + | |
| 740 | + | |
| 741 | + | |
| 742 | + | |
| 743 | + | |
| 744 | + | |
| 745 | + | |
| 746 | + | |
| 747 | + | |
| 748 | + | |
| 749 | + | |
| 750 | + | |
| 751 | + | |
| 752 | + | |
| 753 | + | |
| 754 | + | |
| 755 | + | |
| 756 | + | |
| 757 | + | |
| 758 | + | |
| 759 | + | |
| 760 | + | |
| 761 | + | |
| 762 | + | |
| 763 | + | |
| 764 | + | |
| 765 | + | |
| 766 | + | |
| 767 | + | |
| 768 | + | |
722 | 769 | | |
723 | 770 | | |
724 | 771 | | |
| |||
0 commit comments